Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max coinbase out sigops to CoinbaseOutputDataSize #45

Open
wants to merge 46 commits into
base: sv2
Choose a base branch
from

Conversation

Sjors
Copy link
Owner

@Sjors Sjors commented Jun 18, 2024

Implements stratum-mining/sv2-spec#86 for the Template Provider.

@Sjors
Copy link
Owner Author

Sjors commented Jul 19, 2024

I'll give this a rebase after bitcoin#30440 lands.

@Sjors Sjors force-pushed the sv2 branch 2 times, most recently from 58a98ea to e250789 Compare August 13, 2024 18:57
Sjors and others added 21 commits November 22, 2024 10:14
Implemented starting from a copy of V2Transport and the V2TransportTester,
modifying it to fit Stratum v2 and Noise Protocol requirements.

Co-Authored-By: Christopher Coverdale <[email protected]>
Co-Authored-By: Fi3
Co-Authored-By: Christopher Coverdale <[email protected]>
Co-Authored-By: Vasil Dimov <[email protected]>
Ensure KernelNotifications m_tip_block is set even if no new block arrives.
This change avoids ambiguity when no tip is connected and it is
compared to uint256::ZERO.
Alternate calls between Chainman's ProcessNewBlock and submitSolution. The Chainman code path is used in production, so it's important to keep test coverage for it.

Use createNewBlock via the interface instead of using the BlockAssembler directly. The latter is always called via the interface in production code.
The template provider will listen for a Job Declarator client.
It can establish a connection and detect various protocol errors.

Co-Authored-By: Christopher Coverdale <[email protected]>
Co-Authored-By: Fi3
Co-authored-by: Christopher Coverdale <[email protected]>
Determine future_template only once
@Sjors Sjors reopened this Dec 16, 2024
@Sjors
Copy link
Owner Author

Sjors commented Dec 16, 2024

Rebased on the latest sv2 branch.

This makes the Template Provider backward compatible if the spec is updated.
@Sjors Sjors force-pushed the sv2 branch 3 times, most recently from 8cf7578 to a1c1bd9 Compare December 19, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants