Enabled sonarcloud again on Protocol & Protocol.Features. Made a lot …

…of stuff internal as they aren't needed externally.
SkylineCommunications · Dec 28, 2023 · fbb768c · fbb768c
1 parent 0eacdd5
commit fbb768c
Show file tree

Hide file tree

Showing 540 changed files with 1,798 additions and 1,751 deletions.
diff --git a/Protocol.Features/Common/Attributes/MaxDataMinerVersionsAttribute.cs b/Protocol.Features/Common/Attributes/MaxDataMinerVersionsAttribute.cs
@@ -13,7 +13,7 @@
     /// </summary>
     /// <seealso cref="System.Attribute" />
     [AttributeUsage(AttributeTargets.Class, Inherited = false, AllowMultiple = false)]
-    public sealed class MaxDataMinerVersionsAttribute : Attribute
+    internal sealed class MaxDataMinerVersionsAttribute : Attribute
     {
         public MaxDataMinerVersionsAttribute(string mainRelease, string featureRelease)
         {

diff --git a/Protocol.Features/Common/Attributes/MinDataMinerVersionsAttribute.cs b/Protocol.Features/Common/Attributes/MinDataMinerVersionsAttribute.cs
@@ -13,7 +13,7 @@
     /// </summary>
     /// <seealso cref="System.Attribute" />
     [AttributeUsage(AttributeTargets.Class, Inherited = false, AllowMultiple = false)]
-    public sealed class MinDataMinerVersionsAttribute : Attribute
+    internal sealed class MinDataMinerVersionsAttribute : Attribute
     {
         public MinDataMinerVersionsAttribute(string mainRelease, string featureRelease)
         {

diff --git a/Protocol.Features/Common/Exceptions/DataMinerVersionCheckException.cs b/Protocol.Features/Common/Exceptions/DataMinerVersionCheckException.cs
@@ -3,15 +3,36 @@
     using System;
     using System.Runtime.Serialization;
 
+    /// <summary>
+    /// Represents errors that occur during application execution.
+    /// </summary>
+    /// <seealso cref="System.Exception" />
     [Serializable]
     public class DataMinerVersionCheckException : Exception
     {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="DataMinerVersionCheckException"/> class.
+        /// </summary>
         public DataMinerVersionCheckException() { }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="DataMinerVersionCheckException"/> class.
+        /// </summary>
+        /// <param name="message">The message that describes the error.</param>
         public DataMinerVersionCheckException(string message) : base(message) { }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="DataMinerVersionCheckException"/> class.
+        /// </summary>
+        /// <param name="message">The message.</param>
+        /// <param name="inner">The inner.</param>
         public DataMinerVersionCheckException(string message, Exception inner) : base(message, inner) { }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="DataMinerVersionCheckException"/> class.
+        /// </summary>
+        /// <param name="info">The <see cref="T:System.Runtime.Serialization.SerializationInfo"></see> that holds the serialized object data about the exception being thrown.</param>
+        /// <param name="context">The <see cref="T:System.Runtime.Serialization.StreamingContext"></see> that contains contextual information about the source or destination.</param>
         protected DataMinerVersionCheckException(SerializationInfo info, StreamingContext context) : base(info, context) { }
     }
 }
diff --git a/Protocol.Features/Common/Feature.cs b/Protocol.Features/Common/Feature.cs
@@ -11,7 +11,7 @@
     using Skyline.DataMiner.CICD.Common;
 
     // Inherits IFeature so it always will have the info if we add extra.
-    public class Feature : IFeature
+    internal class Feature : IFeature
     {
         private readonly IFeatureCheck featureCheck;
         private readonly MinDataMinerVersionsAttribute minDmaVersionAttribute;

diff --git a/Protocol.Features/Common/FeatureCheckContext.cs b/Protocol.Features/Common/FeatureCheckContext.cs
@@ -9,7 +9,7 @@
     using Skyline.DataMiner.CICD.Models.Protocol.Read.Interfaces;
     using Skyline.DataMiner.CICD.Validators.Common.Interfaces;
 
-    public class FeatureCheckContext
+    internal class FeatureCheckContext
     {
         public FeatureCheckContext(IProtocolInputData input, IReadOnlyDictionary<ProjectId, CompiledQActionProject> compiledQActions, bool isSolutionBased)
         {

diff --git a/Protocol.Features/Common/FeatureCheckContextExtensions.cs b/Protocol.Features/Common/FeatureCheckContextExtensions.cs
@@ -6,7 +6,7 @@
     using Skyline.DataMiner.CICD.Models.Protocol;
     using Skyline.DataMiner.CICD.Models.Protocol.Read;
 
-    public static class FeatureCheckContextExtensions
+    internal static class FeatureCheckContextExtensions
     {
         public static IEnumerable<(IQActionsQAction qaction, SyntaxTree syntaxTree, SemanticModel semanticModel)> EachQActionProjectsAndSyntaxTreesAndModels(this FeatureCheckContext context)
         {

diff --git a/Protocol.Features/Common/Interfaces/IDmaCheckResults.cs b/Protocol.Features/Common/Interfaces/IDmaCheckResults.cs
@@ -2,8 +2,14 @@
 {
     using System.Collections.Generic;
 
+    /// <summary>
+    /// Holds the features that are used.
+    /// </summary>
     public interface IDmaVersionCheckResults
     {
-        IReadOnlyCollection<Feature> Features { get; }
+        /// <summary>
+        /// Gets the features that are used.
+        /// </summary>
+        IReadOnlyCollection<IFeature> Features { get; }
     }
 }
diff --git a/Protocol.Features/Common/Interfaces/IDmaVersionCheckResult.cs b/Protocol.Features/Common/Interfaces/IDmaVersionCheckResult.cs
diff --git a/Protocol.Features/Common/Interfaces/IFeature.cs b/Protocol.Features/Common/Interfaces/IFeature.cs
@@ -2,12 +2,24 @@
 {
     using System.Collections.Generic;
 
+    /// <summary>
+    /// Represents a feature.
+    /// </summary>
     public interface IFeature
     {
+        /// <summary>
+        /// Gets the title.
+        /// </summary>
         string Title { get; }
 
+        /// <summary>
+        /// Gets the description.
+        /// </summary>
         string Description { get; }
 
+        /// <summary>
+        /// Gets the release notes.
+        /// </summary>
         IReadOnlyCollection<uint> ReleaseNotes { get; }
     }
 }
diff --git a/Protocol.Features/Common/Interfaces/IFeatureCheck.cs b/Protocol.Features/Common/Interfaces/IFeatureCheck.cs
@@ -1,6 +1,6 @@
 namespace SLDisDmFeatureCheck.Common.Interfaces
 {
-    public interface IFeatureCheck : IFeature
+    internal interface IFeatureCheck : IFeature
     {
         IFeatureCheckResult CheckIfUsed(FeatureCheckContext context);
     }

diff --git a/Protocol.Features/Common/Interfaces/IFeatureCheckResult.cs b/Protocol.Features/Common/Interfaces/IFeatureCheckResult.cs
@@ -3,7 +3,7 @@
     using System.Collections.Generic;
     using Results;
 
-    public interface IFeatureCheckResult
+    internal interface IFeatureCheckResult
     {
         bool IsUsed { get; }
 

diff --git a/Protocol.Features/Common/Results/CSharpFeatureCheckResultItem.cs b/Protocol.Features/Common/Results/CSharpFeatureCheckResultItem.cs
@@ -7,7 +7,7 @@
     using Skyline.DataMiner.CICD.CSharpAnalysis.Interfaces;
     using Skyline.DataMiner.CICD.Models.Protocol.Read;
 
-    public class CSharpFeatureCheckResultItem : FeatureCheckResultItem
+    internal class CSharpFeatureCheckResultItem : FeatureCheckResultItem
     {
         public ICSharpObject<SyntaxNode> CSharp { get; }
 

diff --git a/Protocol.Features/Common/Results/DmaVersionCheckResults.cs b/Protocol.Features/Common/Results/DmaVersionCheckResults.cs
@@ -3,13 +3,13 @@
     using System.Collections.Generic;
     using SLDisDmFeatureCheck.Common.Interfaces;
 
-    public class DmaVersionCheckResults : IDmaVersionCheckResults
+    internal class DmaVersionCheckResults : IDmaVersionCheckResults
     {
         internal DmaVersionCheckResults()
         {
             Features = new List<Feature>();
         }
 
-        public IReadOnlyCollection<Feature> Features { get; internal set; }
+        public IReadOnlyCollection<IFeature> Features { get; internal set; }
     }
 }
diff --git a/Protocol.Features/Common/Results/FeatureCheckResult.cs b/Protocol.Features/Common/Results/FeatureCheckResult.cs
@@ -8,7 +8,7 @@
 
     using Skyline.DataMiner.CICD.Models.Protocol.Read;
 
-    public class FeatureCheckResult : IFeatureCheckResult
+    internal class FeatureCheckResult : IFeatureCheckResult
     {
         internal FeatureCheckResult()
         {

diff --git a/Protocol.Features/Common/Results/FeatureCheckResultItem.cs b/Protocol.Features/Common/Results/FeatureCheckResultItem.cs
@@ -4,7 +4,7 @@
 
     using Skyline.DataMiner.CICD.Models.Protocol.Read;
 
-    public class FeatureCheckResultItem
+    internal class FeatureCheckResultItem
     {
         public IReadable Node { get; }
 

diff --git a/Protocol.Features/Features/10.0/Dashboard.cs b/Protocol.Features/Features/10.0/Dashboard.cs
@@ -9,7 +9,7 @@
     using Skyline.DataMiner.CICD.Models.Protocol.Read;
 
     //[MinDataMinerVersions("10.0.0.0-9118", "9.6.11.0-8649")]
-    public class Dashboard : IFeatureCheck
+    internal class Dashboard : IFeatureCheck
     {
         public string Title => "Dashboard";
 

diff --git a/Protocol.Features/Features/10.0/DynamicParameterReplication.cs b/Protocol.Features/Features/10.0/DynamicParameterReplication.cs
@@ -9,7 +9,7 @@
     using Skyline.DataMiner.CICD.Models.Protocol.Read;
 
     //[MinDataMinerVersions("10.0.0.0-9118", "9.6.1.0-7839")]
-    public class DynamicParameterReplication : IFeatureCheck
+    internal class DynamicParameterReplication : IFeatureCheck
     {
         public string Title => "Dynamic Parameter Replication";
 

diff --git a/Protocol.Features/Features/10.0/Exposer.cs b/Protocol.Features/Features/10.0/Exposer.cs
@@ -9,7 +9,7 @@
     using Skyline.DataMiner.CICD.Models.Protocol.Read;
 
     //[MinDataMinerVersions("10.0.0.0-9118", "9.6.5.0-8250")]
-    public class Exposer : IFeatureCheck
+    internal class Exposer : IFeatureCheck
     {
         public string Title => "Exposer";
 

diff --git a/Protocol.Features/Features/10.0/GetPkIdByTableId.cs b/Protocol.Features/Features/10.0/GetPkIdByTableId.cs
@@ -15,7 +15,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.0.0.0-9118", "9.6.13.0-8820")]
-    public class GetPkIdByTableId : IFeatureCheck
+    internal class GetPkIdByTableId : IFeatureCheck
     {
         public string Title => "Get PK ID by Table ID";
 

diff --git a/Protocol.Features/Features/10.0/GetTableIdByColumnId.cs b/Protocol.Features/Features/10.0/GetTableIdByColumnId.cs
@@ -15,7 +15,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.0.0.0-9118", "9.6.13.0-8820")]
-    public class GetTableIdByColumnId : IFeatureCheck
+    internal class GetTableIdByColumnId : IFeatureCheck
     {
         public string Title => "Get Table ID by Column ID";
 

diff --git a/Protocol.Features/Features/10.0/HistorySets_FillArrayNoDelete_Bulk.cs b/Protocol.Features/Features/10.0/HistorySets_FillArrayNoDelete_Bulk.cs
@@ -16,7 +16,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.0.0.0-9118", "9.6.6.0-8270")]
-    public class HistorySets_FillArrayNoDelete_Bulk : IFeatureCheck
+    internal class HistorySets_FillArrayNoDelete_Bulk : IFeatureCheck
     {
         public string Title => "History Sets - FillArrayNoDelete - Bulk";
 

diff --git a/Protocol.Features/Features/10.0/HistorySets_FillArrayWithColumn_Bulk.cs b/Protocol.Features/Features/10.0/HistorySets_FillArrayWithColumn_Bulk.cs
@@ -17,7 +17,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.0.0.0-9118", "9.6.6.0-8270")]
-    public class HistorySets_FillArrayWithColumn_Bulk : IFeatureCheck
+    internal class HistorySets_FillArrayWithColumn_Bulk : IFeatureCheck
     {
         public string Title => "History Sets - FillArrayWithColumn - Bulk";
 

diff --git a/Protocol.Features/Features/10.0/HistorySets_FillArray_Bulk.cs b/Protocol.Features/Features/10.0/HistorySets_FillArray_Bulk.cs
@@ -16,7 +16,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.0.0.0-9118", "9.6.6.0-8270")]
-    public class HistorySets_FillArray_Bulk : IFeatureCheck
+    internal class HistorySets_FillArray_Bulk : IFeatureCheck
     {
         public string Title => "History Sets - FillArray - Bulk";
 

diff --git a/Protocol.Features/Features/10.0/HistorySets_FillArray_Single.cs b/Protocol.Features/Features/10.0/HistorySets_FillArray_Single.cs
@@ -16,7 +16,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     // [MinDataMinerVersions("10.0.0.0-9118", "9.6.13.0-8820")]
-    public class HistorySets_FillArray_Single/* : IFeatureCheck*/
+    internal class HistorySets_FillArray_Single/* : IFeatureCheck*/
     {
         public string Title => "History Sets - FillArray - Single";
 

diff --git a/Protocol.Features/Features/10.0/ProtocolTtlSyntax.cs b/Protocol.Features/Features/10.0/ProtocolTtlSyntax.cs
@@ -10,7 +10,7 @@
     using Skyline.DataMiner.CICD.Models.Protocol.Read;
 
     //[MinDataMinerVersions("10.0.0.0-9118", "9.6.3.0-8092")]
-    public class ProtocolTtlSyntax : IFeatureCheck
+    internal class ProtocolTtlSyntax : IFeatureCheck
     {
         public string Title => "Protocol TTL Syntax";
 

diff --git a/Protocol.Features/Features/10.0/SkipInDiagram.cs b/Protocol.Features/Features/10.0/SkipInDiagram.cs
@@ -9,7 +9,7 @@
     using SLDisDmFeatureCheck.Common.Attributes;
 
     //[MinDataMinerVersions("10.0.0.0-9118", "9.6.4.0-8151")]
-    public class SkipInDiagram : IFeatureCheck
+    internal class SkipInDiagram : IFeatureCheck
     {
         public string Title => "SkipInDiagram";
 

diff --git a/Protocol.Features/Features/10.0/Tooltip.cs b/Protocol.Features/Features/10.0/Tooltip.cs
@@ -9,7 +9,7 @@
     using Skyline.DataMiner.CICD.Models.Protocol.Read;
 
     //[MinDataMinerVersions("10.0.0.0-9118", "9.6.11.0-8649")]
-    public class Tooltip : IFeatureCheck
+    internal class Tooltip : IFeatureCheck
     {
         public string Title => "Tooltip";
 

diff --git a/Protocol.Features/Features/10.0/ValueMapping.cs b/Protocol.Features/Features/10.0/ValueMapping.cs
@@ -9,7 +9,7 @@
     using Skyline.DataMiner.CICD.Models.Protocol.Read;
 
     //[MinDataMinerVersions("10.0.0.0-9118", "10.0.2.0-8924")]
-    public class ValueMapping : IFeatureCheck
+    internal class ValueMapping : IFeatureCheck
     {
         public string Title => "ValueMapping";
 

diff --git a/Protocol.Features/Features/10.1/DeleteFolder_RecycleOption.cs b/Protocol.Features/Features/10.1/DeleteFolder_RecycleOption.cs
@@ -15,7 +15,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.1.0.0-9966", "10.0.3.0-8964")]
-    public class DeleteFolder_RecycleOption : IFeatureCheck
+    internal class DeleteFolder_RecycleOption : IFeatureCheck
     {
         public string Title => "Delete Folder - Recycle Option";
 

diff --git a/Protocol.Features/Features/10.1/DynamicUnits.cs b/Protocol.Features/Features/10.1/DynamicUnits.cs
@@ -10,7 +10,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.1.0.0-9966", "10.0.9.0-9385")]
-    public class DynamicUnits : IFeatureCheck
+    internal class DynamicUnits : IFeatureCheck
     {
         public string Title => "Dynamic Units";
 

diff --git a/Protocol.Features/Features/10.1/ExecuteScript.cs b/Protocol.Features/Features/10.1/ExecuteScript.cs
@@ -15,7 +15,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.1.0.0-9966", "10.0.5.0-9164")]
-    public class ExecuteScript : IFeatureCheck
+    internal class ExecuteScript : IFeatureCheck
     {
         public string Title => "ExecuteScript";
 

diff --git a/Protocol.Features/Features/10.1/InternalLicenses.cs b/Protocol.Features/Features/10.1/InternalLicenses.cs
@@ -9,7 +9,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.1.0.0-9966", "10.0.13.0-9784")]
-    public class InternalLicenses : IFeatureCheck
+    internal class InternalLicenses : IFeatureCheck
     {
         public string Title => "Internal Licenses";
 

diff --git a/Protocol.Features/Features/10.1/LoginMethod_Certificate.cs b/Protocol.Features/Features/10.1/LoginMethod_Certificate.cs
@@ -11,7 +11,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.1.0.0-9966", "10.0.5.0-9164")]
-    public class LoginMethod_Certificate : IFeatureCheck
+    internal class LoginMethod_Certificate : IFeatureCheck
     {
         public string Title => "Login Method - Certificate";
 

diff --git a/Protocol.Features/Features/10.1/MatrixLayout.cs b/Protocol.Features/Features/10.1/MatrixLayout.cs
@@ -10,7 +10,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.1.0.0-9966", "10.0.8.0-9300")]
-    public class MatrixLayout : IFeatureCheck
+    internal class MatrixLayout : IFeatureCheck
     {
         public string Title => "Matrix Layout";
 

diff --git a/Protocol.Features/Features/10.1/NuGet.cs b/Protocol.Features/Features/10.1/NuGet.cs
@@ -12,7 +12,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.1.0.0-9966", "10.0.10.0-9454")]
-    public class NuGetPackages : IFeatureCheck
+    internal class NuGetPackages : IFeatureCheck
     {
         public string Title => "NuGet packages";
 

diff --git a/Protocol.Features/Features/10.1/ProfileHelper.cs b/Protocol.Features/Features/10.1/ProfileHelper.cs
@@ -14,7 +14,7 @@
     using SLDisDmFeatureCheck.Common.Results;
 
     //[MinDataMinerVersions("10.1.0.0-9966", "10.0.8.0-9300")]
-    public class ProfileHelper : IFeatureCheck
+    internal class ProfileHelper : IFeatureCheck
     {
         public string Title => "ProfileHelper";
 

diff --git a/Protocol.Features/Features/10.2/Chain_DefaultSelectionField.cs b/Protocol.Features/Features/10.2/Chain_DefaultSelectionField.cs
@@ -9,7 +9,7 @@
     using Skyline.DataMiner.CICD.Models.Protocol.Read;
 
     [MinDataMinerVersions("10.2.0.0-11517", "10.1.3.0-9963")]
-    public class Chain_DefaultSelectionField : IFeatureCheck
+    internal class Chain_DefaultSelectionField : IFeatureCheck
     {
         public string Title => "Chain Default Selection Field";