Skip to content

Commit

Permalink
Rename extension_limit to extension_limited to make it clear it's a b…
Browse files Browse the repository at this point in the history
…oolean.
  • Loading branch information
romainruaud committed Jan 15, 2025
1 parent 87b2152 commit 01c1c20
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/module-elasticsuite-core/Helper/Autocomplete.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function isExtensionEnabled()
public function isExtensionLimited()
{
return (bool) $this->scopeConfig->isSetFlag(
self::AUTOCOMPLETE_SETTINGS_CONFIG_XML_PREFIX . "/advanced/extension_limit",
self::AUTOCOMPLETE_SETTINGS_CONFIG_XML_PREFIX . "/advanced/extension_limited",
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
);
}
Expand Down
4 changes: 2 additions & 2 deletions src/module-elasticsuite-core/etc/adminhtml/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
</depends>
<comment><![CDATA[Default: No. When set to "Yes", this setting will always proceed to fetch suggestions on the query typed by the user in addition to the extended terms. Eg : When the user is typing "comp", the popular search term "computer" will be suggested, but products or categories matching either "comp" or "computer" will be shown.]]></comment>
</field>
<field id="extension_limit" translate="label comment" type="select" sortOrder="20" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
<field id="extension_limited" translate="label comment" type="select" sortOrder="20" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
<label>Limit the amount of suggested search terms used for autocomplete matching</label>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
<depends>
Expand All @@ -209,7 +209,7 @@
<validate>integer validate-greater-than-zero</validate>
<depends>
<field id="extension_enabled">1</field>
<field id="extension_limit">1</field>
<field id="extension_limited">1</field>
</depends>
<comment><![CDATA[The number of suggested search terms that will be used for fetching results in the autocompletion box.]]></comment>
</field>
Expand Down
2 changes: 1 addition & 1 deletion src/module-elasticsuite-core/etc/config.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
</term_autocomplete>
<advanced>
<extension_enabled>1</extension_enabled>
<extension_limit>0</extension_limit>
<extension_limited>0</extension_limited>
<stop_extension_on_match>0</stop_extension_on_match>
<preserve_base_query>0</preserve_base_query>
</advanced>
Expand Down

0 comments on commit 01c1c20

Please sign in to comment.