SLVS-1721 Fix "Use shared configuration" button not shown after unbind #5907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by making sure that the SharedBindingConfigModel is initialized inside InitializeDataAsync even when project is bound. The problem was that, after unbinding the IsUseSharedBindingButtonVisible was returning false due to the fact that the SharedBindingConfigModel was null. If the property is filled instead should not make any difference in the logic of the dialog
hashicorp-vault-sonar-prod
bot
changed the title
|
gabriela-trutan-sonarsource
requested review from
georgii-borovinskikh-sonarsource and
vnaskos-sonar
and removed request for
georgii-borovinskikh-sonarsource
There was a problem hiding this comment.
The issue is no longer reproducible after #5906 . However, the IsUseSharedBindingButtonVisible tests are still useful!
Comment on lines
+144
to
+147
| var detectSharedBinding = new TaskToPerformParams<AdapterResponse>(CheckForSharedBindingAsync, UiResources.CheckingForSharedBindingText, | ||
| UiResources.CheckingForSharedBindingFailedText) | ||
| { AfterProgressUpdated = OnProgressUpdated }; | ||
| await ProgressReporter.ExecuteTaskWithProgressAsync(detectSharedBinding); |
There was a problem hiding this comment.
The issue seems to be fixed by #5906 This change can be reverted.
There was a problem hiding this comment.
My bad, I started with an unbound project which is not the same.
gabriela-trutan-sonarsource
added a commit
that referenced
this pull request
Dec 18, 2024
vnaskos-sonar
pushed a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1721