Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVS-1729 Promote SQC free plan inside the IDE extensions #5940

Merged
merged 10 commits into from
Jan 9, 2025
Merged

SLVS-1729 Promote SQC free plan inside the IDE extensions #5940

merged 10 commits into from
Jan 9, 2025

Conversation

gabriela-trutan-sonarsource
Copy link
Contributor

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource commented Jan 8, 2025 •
edited by jira bot
Loading

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource changed the base branch from master to feature/hardening-q4 January 8, 2025 12:41
georgii-borovinskikh-sonarsource
georgii-borovinskikh-sonarsource approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor notes. Please rebase feature with master because of the CFamily commit should not be a part of this PR

src/ConnectedMode/UI/ServerSelection/ServerSelectionDialog.xaml Outdated Show resolved Hide resolved
src/Core/Telemetry/TelemetryLinks.cs Outdated Show resolved Hide resolved
src/Integration/Telemetry/TelemetryManager.cs Outdated Show resolved Hide resolved
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource deleted the branch feature/hardening-q4 January 8, 2025 13:50
@vnaskos-sonar vnaskos-sonar reopened this Jan 8, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource merged commit 2832d37 into feature/hardening-q4 Jan 9, 2025
3 checks passed
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource deleted the gt/promote-sqc branch January 9, 2025 08:29
vnaskos-sonar pushed a commit that referenced this pull request Jan 10, 2025
@gabriela-trutan-sonarsource @vnaskos-sonar
SLVS-1729 Promote SQC free plan inside the IDE extensions (#5940)
738cd54
vnaskos-sonar pushed a commit that referenced this pull request Jan 10, 2025
@gabriela-trutan-sonarsource @vnaskos-sonar
SLVS-1729 Promote SQC free plan inside the IDE extensions (#5940)
433b13c
vnaskos-sonar pushed a commit that referenced this pull request Jan 10, 2025
@gabriela-trutan-sonarsource @vnaskos-sonar
SLVS-1729 Promote SQC free plan inside the IDE extensions (#5940)
782273f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabriela-trutan-sonarsource @georgii-borovinskikh-sonarsource @vnaskos-sonar