Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Make tilt green on the first run #84

Merged
merged 1 commit into from
Feb 13, 2024
Merged

🐛 Make tilt green on the first run #84

merged 1 commit into from
Feb 13, 2024

Conversation

chess-knight
Copy link
Member

What this PR does / why we need it:

CSPO template now doesn't need reloading

@chess-knight chess-knight self-assigned this Feb 12, 2024
@chess-knight chess-knight mentioned this pull request Feb 12, 2024
Closed
3 tasks
@cluster-stack-bot cluster-stack-bot bot added the size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. label Feb 12, 2024
michal-gubricky
michal-gubricky approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@michal-gubricky michal-gubricky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kranurag7
kranurag7 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it yesterday couple of times and tilt was able to pick it up when it's starting.
As per this PR, I am concluding that the correct way to wait is to associate the resource using k8s_resource.

LGTM, thank you.

@chess-knight chess-knight merged commit 125a08c into main Feb 13, 2024
5 checks passed
@chess-knight chess-knight deleted the feat/cspotemplate_wo_reload branch February 13, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kranurag7 kranurag7 kranurag7 approved these changes

@michal-gubricky michal-gubricky michal-gubricky approved these changes

Assignees

@chess-knight chess-knight

Labels
size/XS Denotes a PR that changes 0-20 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chess-knight @michal-gubricky @kranurag7