Close #686

backend/website/services/archidekt.py

@@ -3,6 +3,7 @@
 from .json_api import get
 from common.abstractions import Deck, CardInDeck
 from django.conf import settings
+from django.core.exceptions import ValidationError
 
 ARCHIDEKT_HOSTNAME = 'archidekt.com'
 
@@ -36,7 +37,7 @@ def archidekt(url: str) -> Deck | None:
         ]
         return Deck(main=main, commanders=commanders)
     except KeyError:
-        return None
+        raise ValidationError('Invalid decklist')
 
 
 def archidekt_id_to_api(id: str) -> str:

backend/website/services/csv_api.py

@@ -1,6 +1,7 @@
 import csv
 from urllib.request import Request, urlopen
 from urllib.error import HTTPError
+from django.core.exceptions import ValidationError
 from .useragent import FAKE_USERAGENT
 
 
@@ -13,5 +14,9 @@ def get(url: str) -> list[dict[str, object]] | None:
             data = list(csv.reader(res.read().decode('utf-8').splitlines()))
             header = data[0]
             return [dict(zip(header, row, strict=True)) for row in data[1:]]
-    except (HTTPError, csv.Error, ValueError, IndexError):
-        return None
+    except HTTPError as e:
+        if e.code == 404:
+            return None
+        raise ValidationError('Error response from the website')
+    except (csv.Error, ValueError, IndexError):
+        raise ValidationError('Invalid response from the website')

backend/website/services/deckstats.py

@@ -2,6 +2,7 @@
 from urllib.parse import urlparse
 from .json_api import get
 from common.abstractions import Deck, CardInDeck
+from django.core.exceptions import ValidationError
 
 
 DECKSTATS_HOSTNAME = 'deckstats.net'
@@ -42,7 +43,7 @@ def deckstats(url: str) -> Deck | None:
                             main.append(CardInDeck(card=name, quantity=quantity))
         return Deck(main=main, commanders=commanders)
     except KeyError:
-        return None
+        raise ValidationError('Invalid decklist')
 
 
 def deckstats_to_api(owner: str, deck: str) -> str:

backend/website/services/json_api.py

@@ -1,6 +1,7 @@
 import json
 from urllib.request import Request, urlopen
 from urllib.error import HTTPError
+from django.core.exceptions import ValidationError
 from .useragent import FAKE_USERAGENT
 
 
@@ -12,5 +13,9 @@ def get(url: str, user_agent: str | None = None) -> dict | None:
         with urlopen(req) as res:
             data = json.load(res)
             return data
-    except (HTTPError, json.JSONDecodeError):
-        return None
+    except HTTPError as e:
+        if e.code == 404:
+            return None
+        raise ValidationError('Error response from the website')
+    except json.JSONDecodeError:
+        ValidationError('Invalid response from the website')

backend/website/services/moxfield.py

@@ -3,6 +3,7 @@
 from .json_api import get
 from common.abstractions import Deck, CardInDeck
 from django.conf import settings
+from django.core.exceptions import ValidationError
 
 
 MOXFIELD_HOSTNAME = 'moxfield.com'
@@ -31,7 +32,7 @@ def moxfield(url: str) -> Deck | None:
         ]
         return Deck(main=main, commanders=commanders)
     except (KeyError, ValueError, AttributeError):
-        return None
+        raise ValidationError('Invalid decklist')
 
 
 def moxfield_id_to_api(id: str) -> str:

backend/website/services/tappedout.py

@@ -2,6 +2,7 @@
 from urllib.parse import urlparse
 from .csv_api import get
 from common.abstractions import Deck, CardInDeck
+from django.core.exceptions import ValidationError
 
 
 TAPPEDOUT_HOSTNAME = 'tappedout.net'
@@ -32,7 +33,7 @@ def tappedout(url: str) -> Deck | None:
                     main.append(CardInDeck(card=name, quantity=quantity))
         return Deck(main=main, commanders=commanders)
     except (KeyError, ValueError):
-        return None
+        raise ValidationError('Invalid decklist')
 
 
 def tappedout_id_to_api(id: str) -> str:

backend/website/views.py

@@ -43,6 +43,18 @@ class UnsupportedWebsite(APIException):
     default_code = 'unsupported_website'
 
 
+class DecklistNotAvailable(APIException):
+    status_code = 400
+    default_detail = 'Decklist not available'
+    default_code = 'decklist_not_available'
+
+
+class SomethingWentWrong(APIException):
+    status_code = 400
+    default_detail = 'Something went wrong'
+    default_code = 'something_went_wrong'
+
+
 @extend_schema(
     parameters=[OpenApiParameter(name='url', type=str)],
     responses={
@@ -67,9 +79,12 @@ def card_list_from_url(request: Request) -> Response:
     hostname = (parsed_url.hostname or '').lower().removeprefix('www.')
     if hostname not in SUPPORTED_DECKBUILDING_WEBSITES:
         raise UnsupportedWebsite()
-    deck = SUPPORTED_DECKBUILDING_WEBSITES[hostname](url)
-    if deck is None:
-        raise UnsupportedWebsite()
+    try:
+        deck = SUPPORTED_DECKBUILDING_WEBSITES[hostname](url)
+        if deck is None:
+            raise DecklistNotAvailable()
+    except ValidationError as e:
+        raise SomethingWentWrong(detail=str(e))
     return Response(DeckSerializer(deck).data)