Rabbitmq connection setup callback #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does using |
|
As op-rabbit user I am interested for example on logging an alarm instantly and _asynchronously _ when the RabbitMQ connection goes down(and this can be achieved only by registering the connectionSetup callback as the connectionSetup registering is propagated into the amqp driver). Using GetConnectionActor , the user would be forced to regularly query the ConnectionActor state which is not acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The
ConnectionActorof the rabbitmq-client library offers the possibility to register aconnectionSetupcallback that is called every time it manages to connect to RabbitMQ. But op-rabbit currently does not expose such aconnectionSetupcallback in theRabbitControlconstructor so it should as user's of op-rabbit should be allowed to register aconnectionSetupcallback in order to know when a connection goes up or down.