fix some "no AST change" when there are syntax errors #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we unwip and merge? |
andre15silva
changed the title
andre15silva
changed the title
andre15silva
changed the title
|
Sure @monperrus ! Note that the bug is not totally fixed since there are still cases where, even if one of the versions has syntax errors, "no AST change" is outputted. See #305 |
|
thanks @andre15silva |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where there are some syntax errors, gumtree-spoon-ast-diff outputs "no AST change"
This PR fixes that.
Right now, only the most serious cases are fixed.
If there are subtle syntax errors like missing a ";" or ")" and the rest matches, it will still output "no AST change" :/