Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete inactivity messages #200

Merged
merged 6 commits into from
Jan 19, 2025
Merged

Conversation

pauljohanneskraft
Copy link
Collaborator

@pauljohanneskraft pauljohanneskraft commented Jan 14, 2025

Complete inactivity messages

♻️ Current situation & Problem

  • Adds logic to complete inactivity messages whenever a user observation is changed. Before, inactivity messages were created but never completed.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

  • Includes tests to make sure inactive messages are correctly completed.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@pauljohanneskraft pauljohanneskraft added the bug Something isn't working label Jan 14, 2025
@pauljohanneskraft pauljohanneskraft self-assigned this Jan 14, 2025
@pauljohanneskraft pauljohanneskraft marked this pull request as ready for review January 14, 2025 10:43
@pauljohanneskraft pauljohanneskraft linked an issue Jan 14, 2025 that may be closed by this pull request
1 task
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the additional tests; looks great!

Would be great if we can quickly adjust the PR description to describe the PR & the fix in a few minimal bullet points.

@pauljohanneskraft pauljohanneskraft merged commit 90f0a7c into main Jan 19, 2025
6 checks passed
@pauljohanneskraft pauljohanneskraft deleted the complete-inactive-messages branch January 19, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Inactive Message Not Disappear After Perfoming Activity
2 participants