Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brightness Bar to 1.0.3 #732

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

rasitayaz
Copy link
Contributor

@rasitayaz rasitayaz commented Dec 14, 2024

Decky Brightness Bar 1.0.3

  • Fixed "controller settings" page issue again.

When you enter and leave controller settings, brightness bar was stopping working, this update addresses that issue.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is simple, good for testing store.

@rasitayaz, I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request that a member of the SDH team tests your plugin update/submission according to the testing guidelines.

@TrainDoctor TrainDoctor requested review from a team January 13, 2025 00:22
@jwhitlow45
Copy link
Contributor

Decky v3.0.5, SteamOS 3.6.20
A) Any major blocking issues that you encountered, if any.

  • No. Unable to reproduce issue caused by entering "Controller Settings"

B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).

  • Rules from CSS Loader don't appear to be respected by the dropdown brightness bar (or CSS Loader is not applying them in a way that applies to them). Not worth fixing in a bug PR like this, but wanted to note it in case it is intended.. May also be an issue on CSS loader side.

C) A list of currently installed plugins (Name and version preferred)

  • Bluetooth 2.3.0
  • Game Theme Music 1.6.0
  • ProtonDB Badges 1.1.0
  • Audio Loader 1.6.0
  • CSS Loader 2.1.2
  • PowerTools 2.0.3
  • SteamGridDB 1.5.1
  • AutoFlatpaks 1.6.7
  • Animation Changer 1.3.1
  • DeckFAQs 1.8.1
  • vibrantDeck 2.0.1
  • BatteryTracker 0.2.0
  • RadiYo! 1.3
  • Volume Mixer 1.2.1-1
  • Free Loader 1.3.0 (testing version)
  • Tailscale Control 0.1.3

D) Yay/nay on to send to the production store or if it requires more testing.

  • Yay

@Tormak9970
Copy link
Contributor

Testing Report

Versions

Decky: v3.1.2-pre1
SteamOS: v3.6.20 (Stable)

Summary

Major blocking issues

None

Minor issues

None

Currently installed plugins

  • TabMaster - Dev (essentially v2.7.3)
  • CSS Loader - 2.1.2
  • SteamGridDB - 1.4.0

Yay/nay on to send to the production store or if it requires more testing.

Plugin seems to work as expected and the mentioned bug fix is no longer an issue.

@Tormak9970 Tormak9970 mentioned this pull request Jan 13, 2025
6 tasks
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testers approve. Good for production.

@TrainDoctor TrainDoctor merged commit d9d956e into SteamDeckHomebrew:main Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants