-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HLTB-for-Deck to 2.0.4 #742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see someone talking over the HLTB deck plugin :D
@morwy, I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will ensure a member of the SDH team tests your plugin update/submission according to the testing guidelines.
Testing ReportVersionsDecky: v3.1.2-pre1 SummaryMajor blocking issuesNone Minor issuesNone Currently installed plugins
Yay/nay on to send to the production store or if it requires more testing.Looks good to me, everything seems to work fine |
@Tormak9970 thank you very much for your report, @morwy this will be a blocking issue. Please tag me when theme/readability issue is resolved. |
@Tormak9970 it seems that you haven't activated "Clean Gameview" in CSS Loader plugin, according to your screenshots. Here are "Clean", "Clean - Left", "Clean - Default" themes with "Clean Gameview" in CSS Loader. In addition, enabling the theme won't apply it immediately. You have to go to Library and then back to the game page for changes to be applied. I am not the original author, just guessing here. |
@TrainDoctor I am not sure if that is a blocking issue. Please review my comment above. |
I just retested and the issue went away, I think I forgot to leave the library before checking changes. @TrainDoctor I've updated my testing feedback to reflect that |
HLTB for Deck
Warning
This commit changes submodule from https://github.com/SDH-Stewardship/hltb-for-deck to https://github.com/morwy/hltb-for-deck fork due to first one not being maintained for some time.
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing
Tested on SteamOS Stable/Beta Update Channel.
Tested on SteamOS Preview Update Channel.