Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HLTB-for-Deck to 2.0.4 #742

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

morwy
Copy link
Contributor

@morwy morwy commented Jan 5, 2025

HLTB for Deck

Warning

This commit changes submodule from https://github.com/SDH-Stewardship/hltb-for-deck to https://github.com/morwy/hltb-for-deck fork due to first one not being maintained for some time.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

@morwy morwy requested a review from a team as a code owner January 5, 2025 14:17
@morwy morwy changed the title Update HLTB-for-Deck to 2.0.4. Update HLTB-for-Deck to 2.0.4 Jan 5, 2025
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see someone talking over the HLTB deck plugin :D
@morwy, I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will ensure a member of the SDH team tests your plugin update/submission according to the testing guidelines.

@Tormak9970
Copy link
Contributor

Tormak9970 commented Jan 13, 2025

Testing Report

Versions

Decky: v3.1.2-pre1
SteamOS: v3.6.20 (Stable)

Summary

Major blocking issues

None

Minor issues

None

Currently installed plugins

  • TabMaster - Dev (essentially v2.7.3)
  • CSS Loader - 2.1.2
  • SteamGridDB - 1.4.0

Yay/nay on to send to the production store or if it requires more testing.

Looks good to me, everything seems to work fine

@Tormak9970 Tormak9970 mentioned this pull request Jan 13, 2025
6 tasks
@TrainDoctor TrainDoctor requested review from a team January 13, 2025 16:55
@TrainDoctor
Copy link
Member

@Tormak9970 thank you very much for your report, @morwy this will be a blocking issue. Please tag me when theme/readability issue is resolved.

@morwy
Copy link
Contributor Author

morwy commented Jan 13, 2025

@Tormak9970 it seems that you haven't activated "Clean Gameview" in CSS Loader plugin, according to your screenshots.
It seems that "Clean" themes in HLTB will be working without active "Clean Gameview" in CSS Loader, but they will be messed up, according to https://github.com/hulkrelax/hltb-for-deck/releases/tag/v1.1.1.

Here are "Clean", "Clean - Left", "Clean - Default" themes with "Clean Gameview" in CSS Loader.
20250113203849_1
20250113203905_1
20250113203913_1

In addition, enabling the theme won't apply it immediately. You have to go to Library and then back to the game page for changes to be applied.

I am not the original author, just guessing here.

@morwy
Copy link
Contributor Author

morwy commented Jan 13, 2025

@TrainDoctor I am not sure if that is a blocking issue. Please review my comment above.

@Tormak9970
Copy link
Contributor

Tormak9970 commented Jan 13, 2025

@Tormak9970 it seems that you haven't activated "Clean Gameview" in CSS Loader plugin, according to your screenshots. It seems that "Clean" themes in HLTB will be working without active "Clean Gameview" in CSS Loader, but they will be messed up, according to https://github.com/hulkrelax/hltb-for-deck/releases/tag/v1.1.1.

Here are "Clean", "Clean - Left", "Clean - Default" themes with "Clean Gameview" in CSS Loader. 20250113203849_1 20250113203905_1 20250113203913_1

I am not the original author, just guessing here.

I just retested and the issue went away, I think I forgot to leave the library before checking changes. @TrainDoctor I've updated my testing feedback to reflect that

@TrainDoctor TrainDoctor merged commit 38f6261 into SteamDeckHomebrew:main Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants