Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update building and testing instructions #868

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

matteobachetti
Copy link
Member

@matteobachetti matteobachetti commented Dec 29, 2024

Resolve #867
Resolve #862
and other independent reports
We now specify that you need the source code version in order to run the tests with tox or build the documentation.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (ed434c3) to head (c146617).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
- Coverage   96.07%   95.99%   -0.08%     
==========================================
  Files          48       48              
  Lines        9723     9723              
==========================================
- Hits         9341     9334       -7     
- Misses        382      389       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eleonorav89 eleonorav89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it, I would like to ask you to check these colons I indicated in my comments. Thank you for your work!

<https://tox.readthedocs.io>`_ for testing. To run the tests, try::
<https://tox.readthedocs.io>`_ for testing.

If you downloaded the source code, e.g. via `git clone`, run the tests with::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two colons at the end, I interpret it as a typo (see the other comment)

docs/index.rst Outdated
One quick way to build the documentation is using our tox environment: ::
To build the documentation, you will need to clone the development version of Stingray from GitHub.
Once you have the source code, you can go to the root directory and make the build in one of the following ways.
The quickest is probably using our tox environment: ::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again I see the colons, but I do not understand if it is a typo or just some way to explain something. If it is not necessary, I would eliminate the colons at the end of the line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:: in restructuredText introduces literal code blocks, it is described here: https://devguide.python.org/documentation/markup/#source-code

I agree it's a little confusing, because from the way I use it it sometimes gets ignored, sometimes transformed into single colon 😅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the explanation, I didn't know. Perfect then!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the : :: into a single double colon, which gets translated into single colon + literal text block

@matteobachetti matteobachetti added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit b1ce54d Jan 2, 2025
5 checks passed
@matteobachetti matteobachetti deleted the fix_build_instructions branch January 2, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build the documentation Cannot perform tests using tox -e test command
2 participants