Fix #1413 ensure plans always have default pricelists attached (regression) #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjsimpson
had a problem deploying
to
testing
GitHub Actions
Failure
chrisjsimpson
had a problem deploying
to
testing
GitHub Actions
Failure
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue ref: #1413
Fix #1413 ensure plans always have default pricelists attached (regression*)
*Previously all plans were ensured to have default price_lists attached at app start up, causing significantly slow app start-up times (due to sites with 100s of plan revisions (since plans are immutable, each edit creates a new plan id). The app-startup logic to ensure all plans had price_lists was removed (causing the regression). Resolved by ensuring plans have at least default price lists on-access (a crude
len(self.price_lists) > 0check)Screenshot before:
Screenshot after:
How to run test(s) for this PR see: Testing
TODO: app startup time test?