Suppress partition resource changed for TF for total_bytes prop #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always return true to ignore TF resource change check on total_bytes field.
atishya-22
commented
Apr 11, 2023
Comment on lines
+53
to
+55
| DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool { | ||
| return true | ||
| }, |
There was a problem hiding this comment.
@dagould @sumovishal What we are trying to achieve here is to not show that resource has changed during terraform plan if attribute total_bytes has changed.
I could see that always returning true using DiffSuppressFunc can be used to suppress this but not sure if there's better alternative that can be done.
Is there a way to smh ignore this during the serialization of the resource itself?
I can see some other alternatives like ignore_changes, customizeDiff but these doesn’t look like any different than to directly have inside resource schema.
There was a problem hiding this comment.
DiffSuppressFunc is the right way to do it. ignore_changes applies to a resource block, not the provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always return
trueto ignore TF resource change(terraform plan) check on total_bytes field as it will keep changing with data ingested in partition.