Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Remove cmake* from .gitignore #239

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Conversation

N-Dekker
Copy link
Member

@N-Dekker N-Dekker commented Apr 8, 2020

Having cmake* in there stopped Gokhan Gunay from adding his CMakeLists file to pull request #236 (Addition of PointToSurface metric).

Having cmake* in there stopped Gokhan Gunay from adding his CMakeLists file to pull request #236 (Addition of PointToSurface metric).
@N-Dekker N-Dekker requested a review from kaspermarstal April 8, 2020 13:52
@N-Dekker
Copy link
Member Author

N-Dekker commented Apr 8, 2020

@kaspermarstal Is it still useful for you to have "cmake*" in the gitignore list? Apparently it stopped @gokhangg from adding his CMakeLists.txt !

@N-Dekker N-Dekker merged commit 350ff50 into develop Apr 8, 2020
@N-Dekker N-Dekker deleted the Remove-cmake-from-gitignore branch September 3, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant