Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary import #33

Merged
merged 4 commits into from
Apr 16, 2024
Merged

chore: remove unnecessary import #33

merged 4 commits into from
Apr 16, 2024

Conversation

laglangyue
Copy link
Contributor

@laglangyue laglangyue commented Mar 30, 2024 •
edited
Loading

remove some unnecessary import
we not supprot scala 2.12, so we don't need import Seq

@tiagomota tiagomota requested a review from lomigmegard April 11, 2024 12:49
lomigmegard
lomigmegard requested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@lomigmegard lomigmegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the MR! Please rebase on top of master.

The imports formatting should be handled by scalafmt, your changes aren't required.

But indeed some imports aren't used 👍

@laglangyue laglangyue force-pushed the chore_improve_import branch from 1584d32 to 0cb66df Compare April 12, 2024 01:53
@laglangyue
Copy link
Contributor Author

I have been rebeased and exec sbt clean compile with java17 locally

@laglangyue laglangyue requested a review from lomigmegard April 12, 2024 01:56
@lomigmegard
Copy link
Member

@laglangyue thanks, please run sbt scalafmtAll to format according to this repo's rules.

@laglangyue
Copy link
Contributor Author

@laglangyue thanks, please run sbt scalafmtAll to format according to this repo's rules.

done

lomigmegard
lomigmegard approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@lomigmegard lomigmegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lomigmegard lomigmegard changed the title chore: remove unnecessary import and {} chore: remove unnecessary import Apr 16, 2024
@lomigmegard lomigmegard merged commit 19fb859 into SwissBorg:main Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lomigmegard lomigmegard lomigmegard approved these changes

Assignees

@laglangyue laglangyue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laglangyue @lomigmegard