Login command using device auth flow #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still WIP…! - token is stored on disk - login can be done at once or in steps (might be interesting for scripts) - output is not yet done
Instead of the login command, the access token can be specified via an env var
eikek
force-pushed
the
login
branch
2 times, most recently
from
9eb6003 to
558fcd7
Compare
Panaetius
requested changes
Jul 26, 2024
Panaetius
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
logincommand using the device flow. The token is stored on disk in the "application folder" which is picked for each system according to the desktop standard.The http client uses this token if it is available to do requests. After login has run successfully, private projects (with public repos :)) can be cloned with the
clonecommand.The access token can also be specified as an environment variable
RENKU_CLI_ACCESS_TOKEN. In that case, the result from the login command will be ignored.The
openidconnectdependency is nice to use for this task, but one of its dependencies (rsa) has an open vulnerability, see here. This one has been added to the ignore list (of cargo audit and cargo deny).