Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace update methods in db.py files to not use untyped dict[str, Any] input. #485

Open
4 of 8 tasks
leafty opened this issue Oct 25, 2024 · 0 comments
Open
4 of 8 tasks

Replace update methods in db.py files to not use untyped dict[str, Any] input. #485

leafty opened this issue Oct 25, 2024 · 0 comments

Comments

@leafty
Copy link
Member

leafty commented Oct 25, 2024 •
edited
Loading

Using dict[str, Any] prevents type-checking from mypy and can cause bugs, e.g. #483 and #484.

List:
@leafty leafty mentioned this issue Oct 25, 2024
Merged
leafty added a commit that referenced this issue Oct 25, 2024
@leafty
refactor: use typed patch instance for project updates (#486)
bb2c499 
See #485.

Refactor the project update method to used a typed `ProjectPatch` instance. This means that the update code is now type-checked.
This was referenced Oct 25, 2024
Merged
Merged
leafty added a commit that referenced this issue Oct 28, 2024
@leafty @Panaetius
refactor: use typed patch instance for group updates (#487)
2e33051 
See #485.

---------

Co-authored-by: Ralf Grubenmann <[email protected]>
This was referenced Nov 1, 2024
Merged
Merged
Merged
leafty added a commit that referenced this issue Nov 1, 2024
@leafty
refactor: use typed patch instance for user updates (#497)
f1e525a 
See #485.
leafty added a commit that referenced this issue Nov 4, 2024
@leafty
refactor: use typed patch instance for platform config updates (#499)
7b44f99 
See #485.
leafty added a commit that referenced this issue Nov 5, 2024
@leafty
refactor: use typed patch instance for session updates (#500)
b2b7ff2 
See #485.

The session blueprint is also updated to use the `validated_json()` method for API responses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leafty