Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use typed patch instance for user updates #497

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Nov 1, 2024

See #485.

@coveralls
Copy link

coveralls commented Nov 1, 2024

Pull Request Test Coverage Report for Build 11630455581

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 26 of 26 (100.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.01%) to 90.833%

Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/auth.py 1 90.91%
components/renku_data_services/crc/blueprints.py 1 92.88%
components/renku_data_services/crc/models.py 1 85.44%
components/renku_data_services/storage/blueprints.py 1 93.94%
components/renku_data_services/crc/db.py 2 87.5%
Totals Coverage Status
Change from base Build 11630323678: -0.01%
Covered Lines: 11118
Relevant Lines: 12240

💛 - Coveralls

@leafty leafty marked this pull request as ready for review November 1, 2024 10:41
@leafty leafty requested a review from a team as a code owner November 1, 2024 10:41
components/renku_data_services/users/db.py Outdated Show resolved Hide resolved
components/renku_data_services/users/db.py Outdated Show resolved Hide resolved
components/renku_data_services/users/db.py Outdated Show resolved Hide resolved
components/renku_data_services/users/db.py Outdated Show resolved Hide resolved
@leafty leafty requested a review from Panaetius November 1, 2024 11:30
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leafty leafty enabled auto-merge (squash) November 1, 2024 13:53
@leafty leafty merged commit f1e525a into main Nov 1, 2024
11 checks passed
@leafty leafty deleted the leafty/fix-db-update-user branch November 1, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants