[WIP] Logging System 2.0 #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as much as possible
|
Maybe in the dev we should keep the docs/source/, not add in the .gitignore |
liyin2015
reviewed
May 22, 2024
utils/logger.py
Outdated
| Then you can open ./logs/app.log and view the content. | ||
| from utils import BaseLogger | ||
| import logging | ||
| base_logger = BaseLogger(filename='myapp.log', log_level=logging.DEBUG).logger |
| import logging | ||
| import os | ||
| import sys | ||
| from typing import Optional | ||
| import structlog |
There was a problem hiding this comment.
remove structlog from the pyproject.toml
| .. code-block:: python | ||
|
|
||
| #app.log | ||
| 2024-05-20 22:08:28 - utils.logger - INFO - [hotpotqa.py:81] - question: Were Scott Derrickson and Ed Wood of the same nationality? |
There was a problem hiding this comment.
why do we need to show utils.logger there? not much information
| How does the logging system work? | ||
| --------------------------------- | ||
|
|
||
| Our logging system, built on Python’s versatile logging module, introduces a ``BaseLogger`` that simplifies logging setup. This ``BaseLogger`` facilitates both console and file outputs, with configurable ``file path``, ``file name`` and ``log level`. |
There was a problem hiding this comment.
even until this point, i only learned one thing: Lightrag log is built on top of default logging module, i have no idea the benefits
|
Close logging system PR because I combine it with the Document PR, so I can generate doc for it easily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: