Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes embedder tutorial DecreaseEmbeddingDim() class #297

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

ajithvcoder
Copy link
Contributor

What does this PR do?

Fixes #272

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs) Yes
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary) Yes
  • Did you write any new necessary tests? (not for typos and docs) No
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request? No breaking changes

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fm1320 fm1320 force-pushed the fix_embedder_tutorial branch 3 times, most recently from f3cfa3e to cbbab47 Compare December 20, 2024 01:57
@fm1320 fm1320 force-pushed the fix_embedder_tutorial branch from cbbab47 to fee79bc Compare December 20, 2024 02:03
@fm1320 fm1320 merged commit 4e36e14 into SylphAI-Inc:main Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR:adalflow.core.embedder:Error processing the output: 'EmbedderOutput' object is not iterable
2 participants