Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radarr): SQP-1 (2160p) several updates #1628

Closed
wants to merge 2 commits into from
Closed

fix(radarr): SQP-1 (2160p) several updates #1628

wants to merge 2 commits into from

Conversation

TRaSH-
Copy link
Contributor

@TRaSH- TRaSH- commented Nov 12, 2023

Pull Request

Purpose

Fix: #1614
Fix: #1626
Fix: #1627

Approach

  • increase bluray-2160p quality size to compensate for uhd tiers.
  • change maximum quality size for WEB-2160p
  • remove boost from bcore streaming services and lowered it for SQP-1 to -10000

Open Questions and Pre-Merge TODOs

Requirements

@github-actions github-actions bot added Area: Radarr Radarr Related Area: Starr Custom Formats Issue is related to custom formats labels Nov 12, 2023
@TRaSH- TRaSH- requested a review from a team November 12, 2023 16:25
@yammes08
Add new SQP-1 streaming service includes
02742b9 
- Created new includes for SQP-1 streaming service scores
- Updated SQP-1 guide pages to use new SQP-1 streaming service score includes
yammes08
yammes08 approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@yammes08 yammes08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes good, except we also needed new includes for the SQP-1 pages as the streaming service scoring now differs from the other guide pages. I've added these, and built and tested locally.

@yammes08 yammes08 added the Do Not Merge Do Not Merge label Nov 12, 2023
@yammes08
Copy link
Contributor

These are now addressed in #1630 - once that one is merged we'll close this one.

@yammes08 yammes08 mentioned this pull request Nov 12, 2023
Merged
5 tasks
@TRaSH- TRaSH- closed this Nov 12, 2023
@yammes08 yammes08 deleted the fix/radarr-sqp-1-2160p-several-updates branch November 13, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yammes08 yammes08 yammes08 approved these changes

Assignees
No one assigned
Labels
Area: Radarr Radarr Related Area: Starr Custom Formats Issue is related to custom formats Do Not Merge Do Not Merge
Projects
None yet
Milestone
No milestone
2 participants
@TRaSH- @yammes08