Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Guides): Create new Generated Dynamic HDR custom format #2185

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

yammes08
Copy link
Contributor

@yammes08 yammes08 commented Dec 25, 2024

Pull Request

Purpose

Create new Generated Dynamic HDR custom format to match groups who are known to generate their own dynamic HDR metadata.
Resolves #2181

Approach

  • Add known groups to new Generated Dynamic HDR custom format
  • Add release title conditions for matching dynamic HDR types
  • Remove same known groups from existing LQ custom formats
  • Add Generated Dynamic HDR custom format to all Unwanted section panels
  • Add Generated Dynamic HDR custom format to Collection Of... page
  • Add Generated Dynamic HDR custom format to guide profile JSONs

Requirements

Add known groups to new Generated HDR custom format
Add release title conditions for matching dynamic HDR types
Remove same known groups from existing LQ custom formats
Add Generated HDR custom format to all Unwanted section panels
Add Generated HDR custom format to Collection Of... page
Add Generated HDR custom format to guide profile JSONs
@yammes08 yammes08 added Type: Enhancement Feature Request or Improvement of suboptimal status quo Status: Review Needed Ready for Review Area: Radarr Radarr Related Area: Starr Custom Formats Issue is related to custom formats Type: Guide Request Requested new guide or enhancements to guide labels Dec 25, 2024
@yammes08 yammes08 self-assigned this Dec 25, 2024
Copy link
Contributor

@yammes08 your pull request title "feat(Guides)Create new Generated HDR custom format" does not conform to our naming conventions.

Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci(<area>): <description>

You can check your title at this regex101 link."

@github-actions github-actions bot added the Area: Backend Backend Changes, not related to a specific section label Dec 25, 2024
@yammes08 yammes08 changed the title feat(Guides)Create new Generated HDR custom format feat(Guides): Create new Generated HDR custom format Dec 25, 2024
@yammes08 yammes08 requested a review from a team December 25, 2024 14:07
@yammes08 yammes08 marked this pull request as draft December 25, 2024 14:08
@yammes08 yammes08 changed the title feat(Guides): Create new Generated HDR custom format feat(Guides): Create new Generated Dynamic HDR custom format Dec 25, 2024
@yammes08 yammes08 marked this pull request as ready for review December 25, 2024 14:12
Copy link
Contributor

@TRaSH- TRaSH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@TRaSH- TRaSH- merged commit f4738e0 into master Dec 26, 2024
11 checks passed
@TRaSH- TRaSH- deleted the feat/add-new-cf-for-non-retail-dynamic-hdr-groups branch December 26, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Starr Custom Formats Issue is related to custom formats Status: Review Needed Ready for Review Type: Enhancement Feature Request or Improvement of suboptimal status quo Type: Guide Request Requested new guide or enhancements to guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Guides) - New LQ custom format for groups using non-retail dynamic HDR (DV, HDR10+ etc)
2 participants