Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge for v0.5 #13

Merged
merged 29 commits into from
Feb 19, 2024
Merged

merge for v0.5 #13

merged 29 commits into from
Feb 19, 2024

Conversation

raphaelquast
Copy link
Contributor

@raphaelquast raphaelquast commented Nov 27, 2023

This release marks the first stable version of the rt1_model package!

🌦️ Changes

Note

There have been major changes for method-names compared to v0.4 in order to make the API more clear!
All changes primarily affect internals and should not interfere with code that only evaluates the model!
(e.g. code in the example-notebooks remains unchanged etc.)

  • SurfaceScatter and VolumeScatter are now abstract base classes for scattering functions
  • Scatter-objects now define an explicit symbolic version of the scattering angle X.scattering_angle_symbolic
  • ❗ The following methods and properties have been re-named
    • X.legcoefs -> X.legendre_coefficients
    • X.scat_angle_symbolic -> X.scattering_angle_symbolic
    • X._func -> X.phase_function
    • X.scat_angle() -> X.calc_scattering_angle()
    • X.legexpansion() -> X.legendre_expansion()

🔨 Fixes

  • allow passing kwargs to R.surface(), R.volume() and R.interaction()
  • fix clearing geometry cache
  • fix treatment of scalar input values when evaluating the interaction term
  • remove repeated definitions for symbolic scattering angles
  • remove obsolete check for existance of _ncoefs property
  • use random seeds to make notebook-based tests reproducible

@raphaelquast raphaelquast changed the title Dev updates Nov 28, 2023
src/rt1_model/_calc.py Outdated Show resolved Hide resolved
@raphaelquast raphaelquast changed the title updates merge for v0.5 Feb 6, 2024
@raphaelquast raphaelquast merged commit e95df02 into master Feb 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants