-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator Overhaul #527
Validator Overhaul #527
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
+ Coverage 84.55% 93.78% +9.23%
==========================================
Files 9 21 +12
Lines 395 644 +249
Branches 109 156 +47
==========================================
+ Hits 334 604 +270
+ Misses 52 37 -15
+ Partials 9 3 -6 ☔ View full report in Codecov by Sentry. |
eb5957f
to
f9067ab
Compare
d367340
to
1dc351e
Compare
1e47df5
to
5c9667e
Compare
The TypeCheck CI is failing due to this upstream bug in Vue: |
Looks great! |
This PR:
onChange
/onBlur
/other validators to avalidators={{onChange: () => void 0}}
prefixed prop namevalidator
(singular) tovalidatorAdapter
onMount
to match the other APIscreateForm({validators: submit: () => void 0})
APIonSubmit
validation (so that it callsonChange
/onBlur
)validate
andvalidateAsync
to share codeCloses #491