-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#112][FEATURE] DailyNote API 연결 #116
Open
choiyoorim
wants to merge
3
commits into
dev-release
Choose a base branch
from
feature/#112
base: dev-release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiseon37
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생해쑈~
huiseon37
reviewed
Mar 31, 2023
src/lib/api/dayApi.ts
Outdated
Comment on lines
62
to
73
export const postEmojiData = async (data: EmojiRequestType) => { | ||
const post = await client.post('/dailynote', { ...data }); | ||
return post; | ||
}; | ||
|
||
export const postFeelData = async (data: FeelRequestType) => { | ||
const post = await client.post('/dailynote', { ...data }); | ||
return post; | ||
}; | ||
|
||
export const postMemoData = async (data: MemoRequestType) => { | ||
const post = await client.post('/dailynote', { ...data }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 합칠수 있는 방법이 있을건데 한번 내부분 끝나고 나도 손대볼게~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR check list
📝 PR 요약
📌 변경 사항 및 주의 사항
일단 날짜 부분은 고쳐지고 난 다음에 바꿔두도록 하겠습니다
이전과 달리 POST 진행시 각각 Post하도록 바꾸었는데 그이유는 일단 API 보내는 데이터 구조가 바뀌면서
Body 각각을 지정해주어야 하기 때문에 구조를 바꾸었습니다.
더 좋은 방법이 있는지는 고민중...