Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT/#96] 여행 생성 뷰 / 서버 통신 구현 #108

Merged
merged 11 commits into from
Jan 14, 2024

Conversation

leeeyubin
Copy link
Member

@leeeyubin leeeyubin commented Jan 14, 2024

⛳️ Work Description

  • 버튼 활성화 시 서버통신 하기
  • 여행 정보 다른 액티비티로 넘기기

📸 Screenshot

Screen_Recording_20240115_011501_doorip.mp4

📢 To Reviewers

  • 서버 통신 드디어 성공했습니다!!

@leeeyubin leeeyubin added 유빈 ❄ FEAT ✨ 새로운 기능 구현 labels Jan 14, 2024
@leeeyubin leeeyubin self-assigned this Jan 14, 2024
Copy link
Contributor

@crownjoe crownjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 진짜 수고 많았어요~~~~~~~~~~~👍👍👍👍👍👍👍👍👍👍👍🎅🎅🎅🎅🎅🎅👁️👁️

Comment on lines +87 to +88
private fun Request.newAuthBuilder() =
this.newBuilder().addHeader(AUTHORIZATION, "$BEARER ${dataStore.accessToken}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컨s 부탁tv해욥

Comment on lines +96 to +100
val startMonth = String.format(TWO_DIGIT_FORMAT, intent.getIntExtra(START_MONTH, 0))
val startDay = String.format(TWO_DIGIT_FORMAT, intent.getIntExtra(START_DAY, 0))
val endYear = intent.getIntExtra(END_YEAR, 0)
val endMonth = intent.getIntExtra(END_MONTH, 0)
val endDay = intent.getIntExtra(END_DAY, 0)
val endMonth = String.format(TWO_DIGIT_FORMAT, intent.getIntExtra(END_MONTH, 0))
val endDay = String.format(TWO_DIGIT_FORMAT, intent.getIntExtra(END_DAY, 0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변환 수고하셧습니다..하하

Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

유비니 열시미 했어요~ LGTM

Comment on lines 60 to 62
Intent(this, CreateTripActivity::class.java).apply {
startActivity(this)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이동하는 부분도 함수로 빼면 좋을 것 같아요~

@leeeyubin leeeyubin merged commit 7d2a070 into develop Jan 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEAT ✨ 새로운 기능 구현 유빈 ❄
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 여행 생성 뷰 / 서버통신 구현
3 participants