Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/#114] 여행 입장 뷰 / 토스트 위치 수정 #132

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

crownjoe
Copy link
Contributor

@crownjoe crownjoe commented Jan 15, 2024

⛳️ Work Description

  • 토스트 위치 수정

📸 Screenshot

bottomsheet.mp4

📢 To Reviewers

  • 억까 해결!!!!!!!!!!!!!!!!!!ㅋㅋㅋㅋㅋ
  • ㅋㅋ
  • ㅋㅋ
  • 아 ㅎㅎ

Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 잘해,, 왤케 잘해,,, 모든 억까 이겨낸 거 칭찬해~~~~~

Comment on lines 101 to 102
android:exported="true"
android:screenOrientation="portrait" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false 부탁드립니둥

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅎㅎ 수정완 ㅎㅎㅎㅎㅎㅎㅎㅎ하하

Comment on lines 13 to +22

<DatePicker
android:id="@+id/dp_create_trip_date"
<TextView
android:id="@+id/tv_error_toast"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="40dp"
android:calendarTextColor="@color/gray_700"
android:calendarViewShown="false"
android:datePickerMode="spinner"
android:headerDayOfMonthTextAppearance="@style/TextAppearance.Doorip.Body2.Medi"
android:headerMonthTextAppearance="@style/TextAppearance.Doorip.Body2.Medi"
android:headerYearTextAppearance="@style/TextAppearance.Doorip.Body2.Medi"
android:spinnersShown="true"
android:background="@drawable/shape_rect_4_gray700_fill"
android:paddingHorizontal="12dp"
android:paddingVertical="10dp"
android:text="@string/create_trip_toast_error"
android:textColor="@color/white_000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이걸 구현한 언니는,,그저 GOD,,,,

Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 어디가 문제엿삼 결국?

@crownjoe crownjoe merged commit 826987e into develop Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] 여행 생성 뷰 / 토스트 커스텀
4 participants