-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT/#123] OurTodo, MyTodo / EmptyView 구현 #134
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fcc55bd
[FIX/#123] layout_scrollFlags 수정
Marchbreeze d4b0931
Merge branch 'develop' of https://github.com/Team-Going/Going-Android…
Marchbreeze 1ec3c2b
[ADD/#123] StatusBar 색상 Extension 추가
Marchbreeze 4c9d651
[FIX/#123] 흰색 아닌 StatusBar 색상 설정
Marchbreeze 2ea2f16
[FIX/#123] data 모듈 스타일 통일
Marchbreeze 36153b4
[FIX/#123] domain 모듈 스타일 통일
Marchbreeze 1fb7f6e
[FIX/#123] manifest 액티비티 순서 수정
Marchbreeze 1166449
[ADD/#123] MyTodo Empty UI 추가
Marchbreeze 1257151
[FEAT/#123] MyTodo Empty뷰 구현
Marchbreeze a7f5dbb
[UI/#123] MyTodo Empty뷰 UI 수정
Marchbreeze f67fc4a
[FEAT/#123] OurTodo Empty뷰 구현
Marchbreeze b2ec296
[FIX/#123] Empty뷰 위치 수정
Marchbreeze 2ffe4ef
[FEAT/#123] Empty일때 Appbar 스크롤 방지
Marchbreeze 7f95e7c
[ADD/#123] 투두 리스트마다 바텀패딩 부여
Marchbreeze 19a15a4
[FIX/#123] itemDecoration 위치 수정
Marchbreeze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package com.going.ui.extension | ||
|
||
import android.app.Activity | ||
import androidx.core.content.ContextCompat | ||
|
||
fun Activity.setStatusBarColorFromResource(colorResId: Int) { | ||
val statusBarColor = ContextCompat.getColor(this, colorResId) | ||
window.statusBarColor = statusBarColor | ||
} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 4 additions & 5 deletions
9
data/src/main/java/com/going/data/repositoryImpl/ProfileRepositoryImpl.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,15 @@ | ||
package com.going.data.repositoryImpl | ||
|
||
import com.going.data.datasource.AuthDataSource | ||
import com.going.data.datasource.ProfileDataSource | ||
import com.going.domain.entity.request.UserProfileRequestModel | ||
import com.going.domain.repository.AuthRepository | ||
import com.going.domain.repository.ProfileRepository | ||
import javax.inject.Inject | ||
|
||
class ProfileRepositoryImpl @Inject constructor( | ||
private val profileDataSource: ProfileDataSource | ||
) : ProfileRepository { | ||
override suspend fun getUserProfile(): Result<UserProfileRequestModel> = runCatching { | ||
profileDataSource.getUserProfile().data.toProfileModel() | ||
} | ||
override suspend fun getUserProfile(): Result<UserProfileRequestModel> = | ||
runCatching { | ||
profileDataSource.getUserProfile().data.toProfileModel() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,17 @@ | ||
package com.going.presentation.todo.ourtodo | ||
package com.going.presentation.todo | ||
|
||
import android.content.Context | ||
import android.graphics.Rect | ||
import android.view.View | ||
import androidx.recyclerview.widget.RecyclerView | ||
|
||
class OurTodoDecoration(val context: Context) : RecyclerView.ItemDecoration() { | ||
class TodoDecoration( | ||
val context: Context, | ||
private val top: Int, | ||
private val left: Int, | ||
private val right: Int, | ||
private val bottom: Int | ||
) : RecyclerView.ItemDecoration() { | ||
|
||
override fun getItemOffsets( | ||
outRect: Rect, | ||
|
@@ -17,7 +23,10 @@ class OurTodoDecoration(val context: Context) : RecyclerView.ItemDecoration() { | |
val position = parent.getChildAdapterPosition(view) | ||
|
||
if (position == parent.adapter?.itemCount?.minus(1)) { | ||
outRect.right = 150 | ||
outRect.top = top | ||
outRect.left = left | ||
outRect.right = right | ||
outRect.bottom = bottom | ||
Comment on lines
+26
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 오호 데코레이션 좋아요!!!!! |
||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
익스텐션으로 만드셨네요! 전 그냥 작성했었어서 이거 쓰는걸로 바꿔볼게용