[FIX/#148] OurTodo, MyTodo / QA 이슈 대응, Empty뷰 위치 설정 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marchbreeze
requested review from
leeeyubin,
crownjoe and
chattymin
and removed request for
leeeyubin and
crownjoe
crownjoe
approved these changes
Jan 17, 2024
Comment on lines
+16
to
+27
| fun Activity.getWindowHeight(): Int { | ||
| val wm = this.getSystemService(Context.WINDOW_SERVICE) as WindowManager | ||
| return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) { | ||
| val windowMetrics = wm.currentWindowMetrics | ||
| val insets = windowMetrics.windowInsets | ||
| .getInsetsIgnoringVisibility(WindowInsets.Type.systemBars()) | ||
| windowMetrics.bounds.height() - insets.bottom - insets.top | ||
| } else { | ||
| val displayMetrics = DisplayMetrics() | ||
| wm.defaultDisplay.getMetrics(displayMetrics) | ||
| displayMetrics.heightPixels | ||
| } |
Comment on lines
+18
to
26
| 0 -> R.drawable.img_profile_6 | ||
| 1 -> R.drawable.img_profile_1 | ||
| 2 -> R.drawable.img_profile_2 | ||
| 3 -> R.drawable.img_profile_4 | ||
| 4 -> R.drawable.img_profile_5 | ||
| 5 -> R.drawable.img_profile_6 | ||
| 4 -> R.drawable.img_profile_8 | ||
| 5 -> R.drawable.img_profile_5 | ||
| 6 -> R.drawable.img_profile_7 | ||
| else -> R.drawable.img_profile_8 | ||
| else -> R.drawable.img_profile_3 | ||
| } |
leeeyubin
approved these changes
Jan 17, 2024
Comment on lines
+102
to
+103
|
|
||
| const val IS_FIRST_ENTERED = "isFirstEntered" |
Comment on lines
+211
to
+217
| private fun setEmptyViewHeight() { | ||
| binding.appbarOurTodo.addOnOffsetChangedListener { appBarLayout, verticalOffset -> | ||
| val displayHeight = activity?.getWindowHeight() ?: return@addOnOffsetChangedListener | ||
| val toolbarHeight = binding.toolbarOurTodo.height | ||
| val appBarHeight = appBarLayout.totalScrollRange + verticalOffset | ||
| binding.vpOurTodo.layoutParams = (binding.vpOurTodo.layoutParams).also { | ||
| it.height = displayHeight - toolbarHeight - appBarHeight - 300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
KakaoTalk_Video_2024-01-17-23-54-15.mp4
📢 To Reviewers