Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX/#155] OurTodo, MyTodo / Empty 뷰 parent fragment로 이동 #161

Merged
merged 8 commits into from
Jan 17, 2024
Merged

[FIX/#155] OurTodo, MyTodo / Empty 뷰 parent fragment로 이동 #161

merged 8 commits into from
Jan 17, 2024

Conversation

Marchbreeze
Copy link
Member

⛳️ Work Description

  • OurTodo 친구 리스트 바텀 패딩 조절
  • MyTodo Uncomplete 뷰 Empty 수정
  • Empty 뷰 parent fragment로 이동
  • 리스트와 영향 없도록 설정

📸 Screenshot

KakaoTalk_Video_2024-01-18-03-24-33.mp4

📢 To Reviewers

  • 이제 진짜진짜진짜 끝 ~~~~~~~~~

@Marchbreeze Marchbreeze added 상호 🍀 FIX 🔨 버그 및 오류 해결 labels Jan 17, 2024
@Marchbreeze Marchbreeze self-assigned this Jan 17, 2024
chattymin
chattymin approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이걸 해내네요! 굿

buildSrc/src/main/kotlin/Constants.kt
@@ -3,6 +3,6 @@ object Constants {
const val compileSdk = 34
const val minSdk = 28
const val targetSdk = 34
const val versionCode = 6
const val versionCode = 7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

벌써 버전 7~~~~~
가보자가보자

crownjoe
crownjoe approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@crownjoe crownjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이걸 해내네...........

진짜 멋지다 수고했어요!

buildSrc/src/main/kotlin/Constants.kt
@@ -3,6 +3,6 @@ object Constants {
const val compileSdk = 34
const val minSdk = 28
const val targetSdk = 34
const val versionCode = 6
const val versionCode = 7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skrr 7!

@Marchbreeze Marchbreeze merged commit 3fa6cb0 into develop Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crownjoe crownjoe crownjoe approved these changes

@chattymin chattymin chattymin approved these changes

@leeeyubin leeeyubin Awaiting requested review from leeeyubin

Assignees

@Marchbreeze Marchbreeze

Labels
FIX 🔨 버그 및 오류 해결 상호 🍀
Projects
None yet
Milestone
1차 스프린트 마무리 작업
Development

Successfully merging this pull request may close these issues.

[FIX] OurTodo, MyTodo / Empty 뷰 parent fragment로 이동
3 participants
@Marchbreeze @chattymin @crownjoe