[UI/#21] 성향테스트뷰 UI / Animation 구현 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marchbreeze
approved these changes
Jan 4, 2024
Comment on lines
+48
to
+50
| <activity | ||
| android:name="com.going.presentation.tendencytest.TendencyTestSplashActivity" | ||
| android:exported="false" /> |
There was a problem hiding this comment.
이건 몰랐었네요!
이전에 제가 만든 액티비티들에도 다 적용했습니다 :)
| binding.btnTendencySplashStart.setOnSingleClickListener { | ||
| // 페이지 이동~ | ||
| private fun setProgressAnimate(pb: ProgressBar, progressTo: Int) = | ||
| ObjectAnimator.ofInt(pb, "progress", pb.progress, progressTo * 100).apply { |
There was a problem hiding this comment.
"progress" 같은 친구들도 const val로 표시해두면 좋을듯요!
There was a problem hiding this comment.
아 깜빡하고 안했네요!! 수정 완료했습니다
아주 조아용~
| initStartBtnSingleClickListener() | ||
| } | ||
|
|
||
| private fun initStartBtnSingleClickListener() { |
There was a problem hiding this comment.
싱글클릭 말고 다른 리스너 달거 아니면 initStartBtnClickListener로 수정해주셍요 ~
There was a problem hiding this comment.
이게 더 좋은 방법이네요!
매번 적으려 했던 박동민 바보...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
2024-01-04.7.00.35.mov
📢 To Reviewers
어라 폰트 하나 안넣었네요! 빠르게 수정해서 올릴테니 그 부분 제외하고 코리 달아주세용~
-> 폰트 적용 완료