-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI/#47] 여행 생성 완료 뷰 구현 #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
실력이 점점 늘고있는데여!!!! 최고다!!!!
app:title="@string/create_trip_tb_title" | ||
app:titleTextColor="@color/black_000" /> | ||
app:titleTextColor="@color/gray_700" /> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
피그마 반영 좋습니당
android:background="@color/white_000" | ||
android:elevation="2dp" | ||
android:paddingVertical="12dp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elevation
은 어떤 기능인가용..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'z축' 위치를 의미하는데 화면에서 2dp 높이로 떠 있는 것인데 빼는게 맞을 것 같아서 수정하겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
왤케 잘해~~~~!!!!!!!!!!
android:paddingVertical="12dp" | ||
android:paddingStart="18dp" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintHorizontal_bias="0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Horizontal_bias가 무슨 기능일까~요?
지우셔도 됩니당 ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
뷰 수평위치 결정하는 데에 사용하는 것이네욥 수정하겠습니다!
<TextView | ||
android:id="@+id/tv_finish_trip_deadline" | ||
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:layout_marginStart="8dp" | ||
android:paddingVertical="2dp" | ||
android:textAppearance="@style/TextAppearance.Doorip.Detail2.Bold" | ||
android:textColor="@color/red_500" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toTopOf="parent" | ||
android:text="D - " /> | ||
|
||
<TextView | ||
android:id="@+id/tv_finish_trip_deadline_day" | ||
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:layout_marginEnd="8dp" | ||
android:paddingVertical="2dp" | ||
android:textAppearance="@style/TextAppearance.Doorip.Detail2.Bold" | ||
android:textColor="@color/red_500" | ||
app:layout_constraintBottom_toBottomOf="@id/tv_finish_trip_deadline" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintStart_toEndOf="@id/tv_finish_trip_deadline" | ||
app:layout_constraintTop_toTopOf="@id/tv_finish_trip_deadline" | ||
android:text="16" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TextView를 두개 쓰는게 아니라 하나로 합칠 수 있을 것 같네요~
string 리소스에 변수 값 넣는 방법을 찾아보시면 좋을 것 같아요~^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이후에 서버랑 통신해서 뒤에 남은 날짜(숫자)만 바꿔야해서 이게 더 편할 것 같다고 생각했습니다!!>!!!....ㅎ.ㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음~최고네요 괴롭힐게없삼 ㅜ
} | ||
|
||
private fun initCopyCodetvClickListener() { | ||
val inviteCode = viewModel.INVITE_CODE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 친구 한번밖에 안쓰여서 변수로 설정 안하고 그냥 아래에 박아두 될듯 !
binding.tvFinishTripTermsText.setOnSingleClickListener { | ||
val clipboardManager = | ||
this.getSystemService(Context.CLIPBOARD_SERVICE) as ClipboardManager | ||
val clipData = ClipData.newPlainText("Invite Code", inviteCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Invite Code"는 키값으로 보이는데, 따로 const val로 뺴두는 것이 좋아보여용
<TextView | ||
android:id="@+id/tv_finish_trip_dash" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거는 text가 아니라 textView 대신 View를 활용하고, 네이밍도 view로 수정해주셍요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024 .03 .24 - 라 텍스트 뷰로 고대로 가겠숩니닷
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240109_204432_doorip.mp4
📢 To Reviewers
!!! 파이팅 안드👁️👁️🪐🖤❤️🤍📫😎👍