[UI/#44] 취향 태그 뷰 / UI 수정 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crownjoe
approved these changes
Jan 9, 2024
Comment on lines
23
to
+25
| initAdapter() | ||
| initItemDecoration() | ||
| initBackClickListener() |
Comment on lines
+19
to
+21
| if (position == 0) outRect.top = 50 | ||
| else outRect.top = 0 | ||
| outRect.bottom = 10 |
There was a problem hiding this comment.
리사이클러뷰를 이렇게......진짜 유빈 갓이네
Comment on lines
+5
to
+6
| <solid android:color="@color/gray_400" /> | ||
| <corners android:radius="4dp" /> |
There was a problem hiding this comment.
디자인 반영 좋아요~ gray 700 좋습니다~
chattymin
approved these changes
Jan 9, 2024
| android:layout_marginStart="20dp" | ||
| android:layout_marginTop="4dp" | ||
| android:layout_marginBottom="16dp" | ||
| android:text="철저하게" |
There was a problem hiding this comment.
어차피 갈아끼우는 값이긴 하지만, text로 나타내기 보다는 text를 비워두고 tools를 넣어두는 것도 좋을 것 같아요~
Comment on lines
+5
to
+6
| <solid android:color="@color/gray_400" /> | ||
| <corners android:radius="4dp" /> |
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:background="@drawable/shape_rect_topleft5_gray300_fill" | ||
| android:layout_marginTop="16dp" | ||
| android:background="@drawable/ic_preference_union" | ||
| android:gravity="center" |
There was a problem hiding this comment.
center가 없으면 텍스트가 이미지 왼쪽으로 붙어서 가운데로 넣어뒀습니다,,!
Marchbreeze
approved these changes
Jan 9, 2024
| app:layout_constraintTop_toTopOf="parent" | ||
| tools:text="관광" /> | ||
| android:layout_marginTop="4dp" | ||
| android:text="계획은 얼만큼 짤까요?" |
There was a problem hiding this comment.
엇 근데 요거 리사이클러뷰의 아이템이라 어차피 바뀌는 값인데 텍스트 추출 해야 할까용..??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
device-2024-01-09-203908.mp4
📢 To Reviewers