[Feat/#41] sharedpreferences + SignIn + SignUp 분기 처리 및 연결 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marchbreeze
approved these changes
Jan 9, 2024
| @@ -33,7 +33,7 @@ android { | |||
| gradleLocalProperties(rootDir).getProperty("native.app.key"), | |||
| ) | |||
| manifestPlaceholders["NATIVE_APP_KEY"] = | |||
| gradleLocalProperties(rootDir).getProperty("native.app.key") | |||
| gradleLocalProperties(rootDir).getProperty("nativeAppKey") | |||
There was a problem hiding this comment.
김상호 그는 신이야!!! 김상호 그는 신이야!!! 김상호 그는 신이야!!! 김상호 그는 신이야!!! 김상호 그는 신이야!!! 김상호 그는 신이야!!! 김상호 그는 신이야!!! 김상호 그는 신이야!!! 김상호 그는 신이야!!! 김상호 그는 신이야!!! 김상호 그는 신이야!!! 김상호 그는 신이야!!!
Comment on lines
14
to
18
| override suspend fun postLogin( | ||
| Authorization: String, | ||
| platform: SignInRequestDto, | ||
| ): BaseResponse<AuthResponseDto> = | ||
| authService.postSignin(Authorization, platform) |
There was a problem hiding this comment.
Login이랑 SignIn 중에 하나로 통일 부탁드려요 ~
There was a problem hiding this comment.
네~~~~ 수정하다가 저거 빼먹었네욤 하하
| ) : AuthRepository { | ||
| override suspend fun postSignIn( | ||
| Authorization: String, | ||
| data: RequestSignInModel, |
There was a problem hiding this comment.
요것두 data 말고 아래처럼 request~로 가면 더 좋을듯
Comment on lines
4
to
7
| fun getAccessToken(): String | ||
| fun setTokens(accessToken: String, refreshToken: String) | ||
|
|
||
| fun getRefreshToken(): String |
Comment on lines
+81
to
+84
| _postChangeTokenState.value = when (errorCode) { | ||
| SIGN_UP -> SignInState.SIGN_UP | ||
| TENDENCY -> SignInState.TENDENCY | ||
| else -> SignInState.FAIL |
Comment on lines
+99
to
+103
| const val KAKAO = "kakao" | ||
| const val MAX_NAME_LEN = 3 | ||
| const val MAX_INFO_LEN = 20 | ||
| const val SIGN_UP = "e4041" | ||
| const val TENDENCY = "e4045" |
leeeyubin
approved these changes
Jan 9, 2024
Comment on lines
+6
to
+12
| fun toErrorCode(throwable: Throwable): String = if (throwable is HttpException) { | ||
| val jsonTemp = throwable.response()?.errorBody()?.byteString().toString() | ||
| val json = jsonTemp.slice(6 until jsonTemp.length) | ||
| JSONObject(json).getString("code") | ||
| } else { | ||
| "NOT_HTTP" | ||
| } |
Comment on lines
+3
to
+9
| sealed interface SignInState { | ||
| object LOADING : SignInState | ||
| object SUCCESS : SignInState | ||
| object FAIL : SignInState | ||
| object SIGN_UP : SignInState | ||
| object TENDENCY : SignInState | ||
| } |
crownjoe
approved these changes
Jan 9, 2024
Comment on lines
+59
to
+67
| when (state) { | ||
| SignInState.SUCCESS -> navigateToMainScreen() | ||
| SignInState.SIGN_UP -> navigateToOnboardingScreen() | ||
| SignInState.TENDENCY -> navigateToTendencyScreen() | ||
| SignInState.FAIL -> toast(getString(R.string.server_error)) | ||
| SignInState.LOADING -> {} | ||
| } | ||
| }.launchIn(lifecycleScope) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📢 To Reviewers