Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOD/#5] timber logging interceptor #6

Merged
merged 2 commits into from
Dec 28, 2023
Merged

[MOD/#5] timber logging interceptor #6

merged 2 commits into from
Dec 28, 2023

Conversation

chattymin
Copy link
Member

⛳️ Work Description

  • Interceptor Log 기반 -> Timber 기반 변경
  • JsonObject, JsonArray 판정 함수 추가

📢 To Reviewers

  • Log 기반의 Interceptor를 Timber 기반으로 변경하여 릴리즈시 로그를 지워야하는 불편함을 해결했습니다
  • Json형식 판정 함수를 사용하여 로그에 나오는 Json 내용들을 보기좋게 변경하였습니다.

@chattymin chattymin added 동민 🐥 MOD ✅ 코드 수정 및 내부 파일 수정 labels Dec 28, 2023
@chattymin chattymin added this to the 프로젝트 초기 세팅 milestone Dec 28, 2023
@chattymin chattymin self-assigned this Dec 28, 2023
@Marchbreeze Marchbreeze changed the title Mod/#5 timber logging interceptor [MOD/#5] timber logging interceptor Dec 28, 2023
leeeyubin
leeeyubin approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 꿀팁이 있었다니!! 너무 좋네용

Marchbreeze
Marchbreeze approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 조아요 ~~~~!

@chattymin chattymin merged commit 4664dcc into develop Dec 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeeyubin leeeyubin leeeyubin approved these changes

@Marchbreeze Marchbreeze Marchbreeze approved these changes

@crownjoe crownjoe Awaiting requested review from crownjoe

Assignees

@chattymin chattymin

Labels
MOD ✅ 코드 수정 및 내부 파일 수정 동민 🐥
Projects
None yet
Milestone
프로젝트 초기 세팅
Development

Successfully merging this pull request may close these issues.

[MOD] NetworkModule LoggingInterceptor Timber로 변경
3 participants
@chattymin @Marchbreeze @leeeyubin