-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] JWT 기반 소셜 로그인 기능 구현 #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다! 리뷰를 몇 개 남겨보았는데 확인 부탁드려요~!
plu-domain/src/main/kotlin/com/th/plu/domain/config/querydsl/QueryDslConfig.kt
Outdated
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/controller/auth/dto/response/TokenResponseDto.kt
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/service/auth/TokenService.kt
Outdated
Show resolved
Hide resolved
plu-external/src/main/kotlin/com/th/plu/external/client/kakao/WebClientKakaoCaller.kt
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/service/member/MemberServiceUtils.kt
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/controller/auth/dto/request/TokenRequestDto.kt
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/config/interceptor/LoginCheckHandler.kt
Outdated
Show resolved
Hide resolved
val socialId = appleTokenProvider.getSocialIdFromIdToken(request.token) | ||
val member = MemberServiceUtils.findMemberBySocialIdAndSocialType(memberRepository, socialId, socialType) | ||
member.updateFcmToken(request.fcmToken) | ||
return member.id!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!! 연산자
를 통해 Not Nullable임을 명시하여 얻을 수 잇는 어떤 이점이 있을까요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PgmJun Entity 에서 id 는 nullable 하게 구성되어야해서, 해당 응답은 저장된 Entity 라 id 값이 필수라 not null 명시한것같네요
혁준 이거 entity 에서 아래와 같은 패턴 쓰면 좀 더 가독성 좋을것같네요
@Entity
class Member (
@Id
var _id: String?
...
) {
val id : String = _id ?: throw ~
..
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PgmJun Entity 에서 id 는 nullable 하게 구성되어야해서, 해당 응답은 저장된 Entity 라 id 값이 필수라 not null 명시한것같네요
오호 그렇겠네요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getter 사용할 때 좀 더 편리할 수 있을 것 같긴하네요! 우선은 이거 빠르게 머지되어야 다른분들 작업할 수 있으니 이건 우선 스킵할게요
plu-api/src/main/kotlin/com/th/plu/api/controller/auth/dto/response/TokenResponseDto.kt
Show resolved
Hide resolved
plu-external/src/main/kotlin/com/th/plu/external/client/apple/AppleTokenProvider.kt
Show resolved
Hide resolved
plu-external/src/main/kotlin/com/th/plu/external/client/apple/WebClientAppleCaller.kt
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/service/auth/TokenService.kt
Outdated
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/service/auth/TokenService.kt
Outdated
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/service/auth/TokenService.kt
Outdated
Show resolved
Hide resolved
plu-domain/src/main/kotlin/com/th/plu/domain/config/querydsl/QueryDslConfig.kt
Outdated
Show resolved
Hide resolved
최대한 리뷰 내용들 반영해봤어요 한번 확인 부탁드립니다~ |
✒️ 관련 이슈번호
🔑 Key Changes
📸 Screenshot
X
📢 To Reviewers