-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Member 관련 기능 구현 #27
Conversation
plu-domain/src/main/kotlin/com/th/plu/domain/domain/member/repository/MemberRepositoryImpl.kt
Show resolved
Hide resolved
plu-common/src/main/kotlin/com/th/plu/common/exception/code/ErrorCode.kt
Outdated
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/controller/member/MemberController.kt
Outdated
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/service/member/MemberService.kt
Outdated
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/service/member/MemberService.kt
Outdated
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/service/member/MemberService.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셧숴요~! 리뷰 확인 부탁드랴요
plu-api/src/main/kotlin/com/th/plu/api/controller/member/dto/response/MyPageResponse.kt
Outdated
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/service/member/MemberService.kt
Outdated
Show resolved
Hide resolved
plu-api/src/main/kotlin/com/th/plu/api/service/member/MemberValidator.kt
Show resolved
Hide resolved
plu-common/src/main/kotlin/com/th/plu/common/exception/code/ErrorCode.kt
Outdated
Show resolved
Hide resolved
plu-domain/src/main/kotlin/com/th/plu/domain/domain/member/repository/MemberRepositoryImpl.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앞으로 계속 member 의 onboarding 을 가져오려할때 member?.onboarding ?: throw 같은 처리가 매 로직마다 반복되어야할텐데요 (nickname 사용하는 로직마다) 어떻게 처리해보면 좋을지 고민해보면 좋겠네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 리베이스 하면서 잘못 들어간 것 같습니다 ㅜㅜ
✒️ 관련 이슈번호
🔑 Key Changes
📸 Screenshot
📢 To Reviewers