Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Member 관련 기능 구현 #27

Merged
merged 6 commits into from
Mar 10, 2024
Merged

[FEAT] Member 관련 기능 구현 #27

merged 6 commits into from
Mar 10, 2024

Conversation

sookyungg
Copy link
Member

✒️ 관련 이슈번호

🔑 Key Changes

  1. 내용
    • 마이페이지 조회, 닉네임 수정, 닉네임 중복 체크, 회원 탈퇴 api 구현 했습니다.

📸 Screenshot

📢 To Reviewers

@sookyungg sookyungg added the ✨ Feat 기능 개발 label Mar 3, 2024
@sookyungg sookyungg self-assigned this Mar 3, 2024
Copy link
Member

@PgmJun PgmJun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셧숴요~! 리뷰 확인 부탁드랴요

Copy link
Collaborator

@daehwan2da daehwan2da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앞으로 계속 member 의 onboarding 을 가져오려할때 member?.onboarding ?: throw 같은 처리가 매 로직마다 반복되어야할텐데요 (nickname 사용하는 로직마다) 어떻게 처리해보면 좋을지 고민해보면 좋겠네요

Copy link
Member Author

@sookyungg sookyungg Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 리베이스 하면서 잘못 들어간 것 같습니다 ㅜㅜ

@sookyungg sookyungg merged commit ae446d3 into develop Mar 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feat 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Member 관련 기능 구현
4 participants