Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#127 mypage modify #128

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Feature/#127 mypage modify #128

merged 5 commits into from
Oct 8, 2024

Conversation

nagaeng
Copy link
Contributor

@nagaeng nagaeng commented Sep 26, 2024 •
edited
Loading

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • del ) ๋‚ด ์ทจํ–ฅ ๊ด€๋ จ ์ฝ”๋“œ (ํƒญ ์• ๋‹ˆ๋ฉ”์ด์…˜์€ ๋‚จ๊ฒจ๋‘ )
  • ๊ธฐ๋ก, ๋ถ๋งˆํฌ ์— ํ‹ฐ๋ทฐ ๊ธฐ๋ก ๋ฌธ๊ตฌ / ์— ํ‹ฐ๋ทฐ ์ปดํฌ๋„ŒํŠธ ์ƒ๋Œ€ ์œ„์น˜ ์„ค์ •
  • ๋ถ๋งˆํฌ ์— ํ‹ฐ๋ทฐ์—๋„ ๋ฒ„ํŠผ ์ถ”๊ฐ€ ๋ฐ ๋‘˜๋Ÿฌ๋ณด๊ธฐ ํด๋ฆญ ์‹œ ํ™ˆ์œผ๋กœ navigate
  • ๅค– ) color (yellow) opacity ์ˆ˜์ •

๐ŸŒฑ PR ํฌ์ธํŠธ

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

mypage.modify.video.webm

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

๋น„๊ณ 

์— ํ‹ฐ๋ทฐ ์—์…‹ ์ถ”๊ฐ€ ํ•„์š”

@nagaeng nagaeng added ๊ธฐ๋Šฅ๊ตฌํ˜„ Skrr ๋‚˜๊ฒฝ ๐Ÿชผ๐Ÿน ๋ ˆ์ฝ”๋”” ๊ฐ“๊ธฐ ๋‚˜๊ฐฑ์ด๊บผ labels Sep 26, 2024
@nagaeng nagaeng self-assigned this Sep 26, 2024
cacaocoffee
cacaocoffee approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@cacaocoffee cacaocoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ–ˆ์–ด์š”!

lsakee
lsakee approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@lsakee lsakee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG ULTRA TV

@nagaeng nagaeng merged commit fb82158 into develop Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sangwook123 Sangwook123 Sangwook123 approved these changes

@lsakee lsakee lsakee approved these changes

@cacaocoffee cacaocoffee cacaocoffee approved these changes

@seohee0925 seohee0925 Awaiting requested review from seohee0925

Assignees

@nagaeng nagaeng

Labels
๊ธฐ๋Šฅ๊ตฌํ˜„ Skrr ๋‚˜๊ฒฝ ๐Ÿชผ๐Ÿน ๋ ˆ์ฝ”๋”” ๊ฐ“๊ธฐ ๋‚˜๊ฐฑ์ด๊บผ
Projects
None yet
Milestone
UI ์ž‘์—… ๋ฐ ๊ธฐ๋Šฅ ๊ตฌํ˜„
Development

Successfully merging this pull request may close these issues.

[feat] mypage ๋ณ€๊ฒฝ ์‚ฌํ•ญ ์ˆ˜์ •
4 participants
@nagaeng @cacaocoffee @lsakee @Sangwook123