Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#129 place detail UI #132

Merged
merged 12 commits into from
Oct 13, 2024
Merged

Feature/#129 place detail UI #132

merged 12 commits into from
Oct 13, 2024

Conversation

nagaeng
Copy link
Contributor

@nagaeng nagaeng commented Oct 5, 2024

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ์žฅ์†Œ detail ui ๋ ....

๐ŸŒฑ PR ํฌ์ธํŠธ

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

detail.page.data.x.mp4
detail.page.data.o.mp4

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

Copy link
Member

@cacaocoffee cacaocoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์–ด์š” ํ™•์ธํ•ด๋ดค๋Š”๋ฐ ํ™”๋ฉด ui ๋„ ์ž˜๋งž๋Š”๊ฑฐ ๊ฐ™๋„ค์š”

postSideEffect(DetailpageSideEffect.NavigateToVideoDetail(type, videoId))
}

fun fetchPlaceInfo() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด ํ•จ์ˆ˜๋Š” ์ถ”ํ›„ API ์—ฐ๊ฒฐ์„ ์œ„ํ•œ๊ฑด๊ฐ€์š”?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ •๋‹ต์ž…๋‹ˆ๋‹ค~~

Copy link
Contributor

@seohee0925 seohee0925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hilt๊นŒ์ง€ ์•ผ๋ฌผ๋”ฑ์ง€๊ฒŒ ๋„˜ ์ž˜ํ•˜์…จ๋„ค์š”
์ˆ˜๊ณ ํ–ˆ์–ด์šฉ

Copy link
Contributor

@Sangwook123 Sangwook123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ–ˆ์–ด์š”~ ๋„ˆ๋ฌด ์ž˜ํ–ˆ๋„ค์š” ํ•˜๋‚˜๋งŒ ์ˆ˜์ • ๋ถ€ํƒ

Copy link
Contributor

@Sangwook123 Sangwook123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตฟ! ๋จธ์ง€ํ•ฉ์‹œ๋‹ค

@nagaeng nagaeng merged commit a122def into develop Oct 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๊ธฐ๋Šฅ๊ตฌํ˜„ Skrr ๋‚˜๊ฒฝ ๐Ÿชผ๐Ÿน ๋ ˆ์ฝ”๋”” ๊ฐ“๊ธฐ ๋‚˜๊ฐฑ์ด๊บผ ์Œˆ๋ฝ•ํ•œ UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] space detail ui
4 participants