Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#62 video upload UI #138

Merged
merged 5 commits into from
Oct 26, 2024
Merged

Feature/#62 video upload UI #138

merged 5 commits into from
Oct 26, 2024

Conversation

lsakee
Copy link
Contributor

@lsakee lsakee commented Oct 20, 2024

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ui ๋ณ€๊ฒฝ ์ ์šฉ

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
ํŒŒ์ผ์ฒจ๋ถ€๋ฐ”๋žŒ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

  • Resolved: #์ด์Šˆ๋ฒˆํ˜ธ

cacaocoffee
cacaocoffee approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@cacaocoffee cacaocoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค!

feature/mypage/src/main/java/com/record/mypage/MypageScreen.kt
onLoadMoreRecords: () -> Unit,
onLoadMoreBookmarks: () -> Unit,
navigateVideoHome: () -> Unit,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navigateTo ๊ฐ€ ๋ถ™๋Š”๊ฑฐ๋ž‘ navigate๋งŒ ์žˆ๋Š” ๊ฒƒ์˜ ์ฐจ์ด๋Š” ๋ญ”๊ฐ€์š”?

nagaeng
nagaeng approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@nagaeng nagaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOOG ๋‘‘ ใ…‹ใ…‹ ๐Ÿ‘
๊ทผ๋ฐ ์—„๋งˆ ๋ผ๋ฒจ๋ง์ด๋ž‘ ์ปจ๋ฒค์…˜์€ ์–ด๋”ฐ ๋ฒ„๋ ธ์–ด์š”?

@lsakee lsakee merged commit e1ebc05 into develop Oct 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sangwook123 Sangwook123 Sangwook123 approved these changes

@nagaeng nagaeng nagaeng approved these changes

@cacaocoffee cacaocoffee cacaocoffee approved these changes

@seohee0925 seohee0925 Awaiting requested review from seohee0925

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsakee @cacaocoffee @nagaeng @Sangwook123