Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve versioning of built APK #19

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

litetex
Copy link
Member

@litetex litetex commented Oct 27, 2024

Include current version id/number inside version name and code for better identification

I'm currently experimenting with the Nightly and how to get it into an F-Droid repo.
So far it looks quite good however all nightly builds have the same version and name which confuses F-Droid.

Example

More details in TeamNewPipe/NewPipe#11656

@TobiGr
Copy link
Contributor

TobiGr commented Oct 27, 2024

After merging this PR one will not be able to update from an older nightly because the version code will be lower. We need to communicate this in the release notes of the first affected nightly and add tell the testers to backup and restore their data.

@litetex litetex marked this pull request as ready for review October 27, 2024 20:46
@litetex
Copy link
Member Author

litetex commented Oct 27, 2024

After merging this PR one will not be able to update from an older nightly because the version code will be lower. We need to communicate this in the release notes of the first affected nightly and add tell the testers to backup and restore their data.

Good point.
We could maybe manually create a tag called nightly-1000 so that the version is above the currently set 999.

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Include current version id/number inside version name and code for better identification
@litetex
Copy link
Member Author

litetex commented Oct 28, 2024

Merging now, we will see if the new system works

@litetex litetex merged commit 7018b09 into TeamNewPipe:github_actions Oct 28, 2024
@litetex
Copy link
Member Author

litetex commented Oct 28, 2024

Looks good :D

@Stypox
Copy link
Member

Stypox commented Oct 28, 2024

How do you obtain an F-Droid repository?

@litetex
Copy link
Member Author

litetex commented Oct 28, 2024

How do you obtain an F-Droid repository?

I'm still experimenting with this but basically it works like this:

  1. Get f-droid tools (currently released tools are broken and current Docker image is not working) and configure them
  2. Get APKs (maybe with an automated script)
  3. Run fdroid update && fdroid deploy
  4. Profit!

See also: https://f-droid.org/en/docs/Setup_an_F-Droid_App_Repo/#overview

I will try do some further testing in the next time and post updates here or on our matrix channel.

@litetex litetex deleted the better-versioning branch October 28, 2024 21:41
@Stypox
Copy link
Member

Stypox commented Oct 28, 2024

Oh okok, I thought you set up the client to load the APKs directly from github or something ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants