Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayerHolder refactor #11867

Open
wants to merge 6 commits into
base: refactor
Choose a base branch
from

Conversation

Profpatsch
Copy link
Contributor

This simplifies the PlayerHolder a bit.

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • record videos
  • create clones
  • take over the world

Before/After Screenshots/Screen Record

  • Before:
  • After:

Fixes the following issue(s)

  • Fixes #

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

The player in playerHolder is exactly the player inside the
`PlayerService`, which in turn is exactly passed through the IBinder
interface. Thus we don’t have to pass both.

Instead add `PlayerService.getPlayer()`.

Also inline a few methods of `PlayerHolder` and simplify.
Only used once. Now the code looks weird … why is the service started
twice??
Should make it easier to seperate the two further later, both of them
are only implemented by VideoDetailFragment anyway, which is kind of a
code smell!
@Profpatsch Profpatsch added codequality Improvements to the codebase to improve the code quality size/large PRs with less than 750 changed lines rewrite Issues and PRs related to rewrite labels Jan 1, 2025
@github-actions github-actions bot added size/medium PRs with less than 250 changed lines and removed size/large PRs with less than 750 changed lines labels Jan 1, 2025
Copy link

sonarqubecloud bot commented Jan 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality rewrite Issues and PRs related to rewrite size/medium PRs with less than 250 changed lines
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant