Feat: comp_visual_preset #289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR based on the old one, with clean history. I still don't know how the old one broke.
This is a comp entity that allows users to set presets for tone mapping, fog and color correction, all handled by one entity.
For tone mapping this entity supports setting: AutoExposureMax, AutoExposureMin, Bloom, BloomExponent
For fog: Primary color, Fog Start, Fog End, Fog Max Density, Lerping (for the values specified before)
For CC: Filename (which gets specified as an actual filename, evaluates to: materials/correction/.raw)
When Apply is fired to this entity, it fires respective IO to specified fog_controller, tonemapper and color_correction entity, as mentioned before it features lerping. It also automatically disables other comp_visual_presets making sure only one is active at a time.
Not specifying cc_filename, tonemapper or fog_controller just disables these features respectively.