Added Opened status for Sentinel PR #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please change the checker with the new category |
|
Please rebase your changes on the latest |
|
Not sure if you're working on |
hermya
force-pushed
the
fix-time-flaky-sentinel
branch
from
4c3ecf9 to
a7c761c
Compare
|
Can you squash 8 commits into 1? You're just adding one new line, so no need for 8 commits to ad one line. |
hermya
force-pushed
the
fix-time-flaky-sentinel
branch
from
a44c5b0 to
eaf052a
Compare
|
This PR currently has some unnecessary changes in |
hermya
force-pushed
the
fix-time-flaky-sentinel
branch
2 times, most recently
from
b3491bc to
4c419d6
Compare
hermya
force-pushed
the
fix-time-flaky-sentinel
branch
from
bea1578 to
991aa40
Compare
|
Apologies for taking so many tries to reduce the changes to one commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Opened status for time zone dependent test, with PR at: alibaba/Sentinel#3459