Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a screenshot location switch #30

Merged
merged 8 commits into from
Feb 19, 2024
Merged

Conversation

davep
Copy link
Contributor

@davep davep commented Feb 15, 2024

Adds --screenshot-path and --screenshot-filename as parameters to the textual command, to be used in conjunction with --screenshot.

Required to help implement Textualize/textual#3795

See also Textualize/textual#4181 -- this PR needs to go into Textual before this can be sensibly released.

(Also updates black to keep up with what Textual uses)

@davep davep added the enhancement New feature or request label Feb 15, 2024
@davep davep self-assigned this Feb 15, 2024
@davep
Copy link
Contributor Author

davep commented Feb 19, 2024

Although I can merge this anyway... I've requested a glance over first.

Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davep davep merged commit e902fe3 into Textualize:main Feb 19, 2024
16 checks passed
@davep davep deleted the screenshot-location branch February 19, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants