Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken attack of GLA Bomb Truck #1127

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

psykana
Copy link
Contributor

@psykana psykana commented Apr 1, 2024

Fixes #888.

Weapon templates from #888 (IDs 1265 and 1267) don't damage enemies directly, but rather kill themselves and deal damage with Object::On_Die effects. Due to an incorrect coordinate here (probably a typo), damage doesn't apply and nothing happens.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 2.53%. Comparing base (54999d2) to head (84f7b30).

Files Patch % Lines
src/game/logic/object/weapon.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1127   +/-   ##
========================================
  Coverage     2.53%    2.53%           
========================================
  Files          949      949           
  Lines       110747   110747           
  Branches     18995    18995           
========================================
  Hits          2802     2802           
  Misses      107542   107542           
  Partials       403      403           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xezon xezon changed the title Fix GLA postal service Fix broken attack of GLA Bomb Truck Apr 1, 2024
@xezon xezon merged commit 9a10575 into TheAssemblyArmada:develop Apr 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLA Bomb Truck can no longer attack
3 participants