Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template: remove mention of solutions branch #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoshDevHub
Copy link
Contributor

Because

With #109, the solutions to the exercises in this repo have been moved from their own branch to the top-level solutions directory in the main branch. Therefore mention of the unused solutions branch should be removed from the PR template.

This PR

  • Remove mention of solutions branch in PR template

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Data types exercise: Update spec files
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section

@@ -29,4 +29,3 @@ Closes #XXXXX
- [ ] The `Because` section summarizes the reason for this PR
- [ ] The `This PR` section has a bullet point list describing the changes in this PR
- [ ] If this PR addresses an open issue, it is linked in the `Issue` section
- [ ] If this PR includes changes that needs to be updated on the `solutions` branch, I have created another PR (and linked it to this PR).
Copy link
Member

@rlmoser99 rlmoser99 Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should change this to something like this, because the purpose of this is to remind people that they may have to make changes in two places.

[ ] If this PR includes changes to exercises, they are also changed in the `solutions` folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants