Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show project partners #26

Closed
Tracked by #24
gannebamm opened this issue Jul 19, 2024 · 15 comments
Closed
Tracked by #24

Show project partners #26

gannebamm opened this issue Jul 19, 2024 · 15 comments
Assignees
Labels

Comments

@gannebamm
Copy link
Contributor

This issue is part of #24

Problem: The current GeoNode Version 4.x is a single page application. It will not show the project partners in the footer element like version 3.x.

Objective: As administrator I want to show project partners logos. An example of the functionality is shown at the current Thünen ATLAS (https://atlas.thuenen.de/) which is based on version 3.x of GeoNode:

In the screenshot below the homepage of the Thünen ATLAS is shown. In the footer area the partners are listed with their logos.
grafik

The screenshot below is showing the version 4.x homepage. The partners and logos are no longer displayed. A possible placement would be in the footer element of the start page.
grafik

@kilichenko-pixida
Copy link
Contributor

Current state of the footer when using the subsites module:

footer
5362031949549526383

Not sure whether logos should be centered or to the left

@ridoo
Copy link
Collaborator

ridoo commented Sep 3, 2024

@kilichenko-pixida please test making style changes via admin theme and if changes do not apply ask upstream for help.

@ridoo
Copy link
Collaborator

ridoo commented Sep 17, 2024

There had been a small discussion around the topic here: geosolutions-it/geonode-subsites#42

Documentation has been updated: https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/blob/subsite_holisoils/geonode/templates/subsites/README.md

@ridoo
Copy link
Collaborator

ridoo commented Sep 17, 2024

Discussion on theme/styling when deployed on https://geonode-demo.thuenen.de/#/

@gannebamm
Copy link
Contributor Author

In the template some of the cards are not shown completly and the bottom is cut by the project partners:

base template:
Image

subsite template:
Image

@ridoo
Copy link
Collaborator

ridoo commented Oct 16, 2024

footer issue fix to be tested: 22a0228

TODO: @ridoo check broken footer links

@kilichenko-pixida
Copy link
Contributor

Can't reproduce the footer issue after the fix, here is what it looks like for me locally on the latest version of thuenen_4.x
@ridoo @gannebamm

Image

@ridoo
Copy link
Collaborator

ridoo commented Oct 16, 2024

@gannebamm as expected the dead links were related to a wrong ordering of the urlpatterns. I pushed a fix just now. Feel free to test

@gannebamm
Copy link
Contributor Author

Some things are fixed but there are still some CSS glitches:

Expected
Image

You can see the dot and some space at the end of scrolling.

Behaviour
Image

lots of empty space and vertical scrol even though it is not needed.

https://geonode-demo.thuenen.de/holisoils/catalogue/#/maps

@kilichenko-pixida
Copy link
Contributor

kilichenko-pixida commented Oct 18, 2024

Some things are fixed but there are still some CSS glitches:

I'll look into it

@kilichenko-pixida
Copy link
Contributor

kilichenko-pixida commented Oct 21, 2024

@gannebamm It seems to me the reason this empty space appears is due to only having one resource selected and is not related to the subsites. I've tried to test it both locally and on stable (without subsites), and if there are very few resources to fill the space (e.g. just 1), that's how it's being displayed, browser sizing doesn't seem to affect it. Here is a screenshot from stable:

screenshot

Let me know if this is something that still needs to be addressed or I am just missing something

@vineetasharma105
Copy link
Contributor

Hi ,
If I may add one point here, the scroll bar should not be there when there are no more layers available. On the stable version, as you have also shown, there is still some space , but its without 'scroll bar' and has a very clean look. Image
Also, I checked the screenshots in the documentation part also here https://docs.geonode.org/en/master/basic/theme/index.html , where it has no resources, still it has clean look and without scroll bar. Image
The white space is justified though.

@kilichenko-pixida
Copy link
Contributor

@vineetasharma105 Ah, I see your point, thanks, I'll look for a fix s.t. the scroll bar doesn't appear

@kilichenko-pixida
Copy link
Contributor

kilichenko-pixida commented Oct 30, 2024

@vineetasharma105 I looked into it and it seems that the observed difference is not due to the footer, but due to the different layout shown in this example (with pages, as seen in the url with &page=1) the scrollbar also disappears on the holisoils subsite. Also, on the screenshot I attached above of the single resource seen on stable the scroll bar was actually also present, just was cut out of the screenshot

paging

@gannebamm
Copy link
Contributor Author

I think we are done here, right @VeraZimt @vineetasharma105? Otherwise reopen with comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants